Call scrollbarsChanged in PLSA::updateAfterStyleChange.

Call scrollbarsChanged in PLSA::updateAfterStyleChange.

This matches the call in updateAfterLayout (for auto scrollbars), and is needed
to ensure that LayoutBlockFlow::layoutBlockFlow sets relayoutChildren = true.

BUG=576304
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/4fc7dec0128b48b0f4d26d36e128a4d0c9d5d435
Cr-Commit-Position: refs/heads/master@{#434018}

[skobes, 2016-11-21 20:44:54]

Description was changed from

==========
Call scrollbarsChanged from PLSA::updateAfterStyleChange.

This matches what we do for auto scrollbars in updateAfterLayout, and is needed
to ensure that LayoutBlockFlow::layoutBlockFlow sets relayoutChildren correctly.

BUG=576304
==========

to

==========
Call scrollbarsChanged from PLSA::updateAfterStyleChange.

This matches what we do for auto scrollbars in updateAfterLayout, and is needed
to ensure that LayoutBlockFlow::layoutBlockFlow sets relayoutChildren correctly.

BUG=576304
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[skobes, 2016-11-21 20:45:01]

The CQ bit was checked by skobes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 20:45:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skobes, 2016-11-21 20:46:59]

Description was changed from

==========
Call scrollbarsChanged from PLSA::updateAfterStyleChange.

This matches what we do for auto scrollbars in updateAfterLayout, and is needed
to ensure that LayoutBlockFlow::layoutBlockFlow sets relayoutChildren correctly.

BUG=576304
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Call scrollbarsChanged in PLSA::updateAfterStyleChange.

This matches the call in updateAfterLayout (for auto scrollbars), and is needed
to ensure that LayoutBlockFlow::layoutBlockFlow sets relayoutChildren correctly.

BUG=576304
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[skobes, 2016-11-21 20:47:12]

Description was changed from

==========
Call scrollbarsChanged in PLSA::updateAfterStyleChange.

This matches the call in updateAfterLayout (for auto scrollbars), and is needed
to ensure that LayoutBlockFlow::layoutBlockFlow sets relayoutChildren correctly.

BUG=576304
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Call scrollbarsChanged in PLSA::updateAfterStyleChange.

This matches the call in updateAfterLayout (for auto scrollbars), and is needed
to ensure that LayoutBlockFlow::layoutBlockFlow sets relayoutChildren = true.

BUG=576304
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[skobes, 2016-11-21 20:48:28]

The CQ bit was checked by skobes@chromium.org to run a CQ dry run

[skobes, 2016-11-21 20:48:38]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-11-21 20:49:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skobes, 2016-11-21 20:50:09]

skobes@chromium.org changed reviewers:
+ atotic@chromium.org

[atotic, 2016-11-21 22:09:06]

https://codereview.chromium.org/2523533002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp (right):

https://codereview.chromium.org/2523533002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp:935:
toLayoutBlock(box()).scrollbarsChanged(horizontalScrollbarChanged,
box() can return null. Looking at existing code, it looks like everyone else
assumes it will never return null, so I guess it is ok.

box() is a LayoutBox. To typecast to LayoutBlock you need a guard:

   if (box().isLayoutBlock())

[skobes, 2016-11-21 22:18:38]

The CQ bit was checked by skobes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 22:18:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skobes, 2016-11-21 22:18:51]

https://codereview.chromium.org/2523533002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp (right):

https://codereview.chromium.org/2523533002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp:935:
toLayoutBlock(box()).scrollbarsChanged(horizontalScrollbarChanged,
On 2016/11/21 22:09:06, atotic2 wrote:
> box() can return null.

It returns a reference, so it cannot be null.

> box() is a LayoutBox. To typecast to LayoutBlock you need a guard:
> 
>    if (box().isLayoutBlock()) 

Done.

[atotic, 2016-11-21 22:24:11]

lgtm

[skobes, 2016-11-21 22:26:52]

The CQ bit was unchecked by skobes@chromium.org

[skobes, 2016-11-21 22:27:02]

The CQ bit was checked by skobes@chromium.org

[commit-bot: I haz the power, 2016-11-21 22:27:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 23:56:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 23:56:40]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[skobes, 2016-11-22 02:21:37]

The CQ bit was checked by skobes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 02:22:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 04:22:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 04:22:14]

Dry run: This issue passed the CQ dry run.

[skobes, 2016-11-22 04:32:01]

PTAL - updated to address failure in fast/table/overflowHidden.html.  It looks
like the intrinsic padding adjustments in LayoutTableCell::scrollbarsChanged are
only meant to run during layout.

[atotic, 2016-11-22 23:01:20]

On 2016/11/22 at 04:32:01, skobes wrote:
> PTAL - updated to address failure in fast/table/overflowHidden.html.  It looks
like the intrinsic padding adjustments in LayoutTableCell::scrollbarsChanged are
only meant to run during layout.

lgtm.

I wondered whether scrollbarsChanged interacted with any other elements, looks
like TableCell is the only one. And with this change, TableCell will ignore all
new calls.

[skobes, 2016-11-22 23:05:19]

The CQ bit was checked by skobes@chromium.org

[commit-bot: I haz the power, 2016-11-22 23:06:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 23:18:52]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1479855919303730,
"parent_rev": "7ad8cf5580951e860edf933e26b115647c36d624", "commit_rev":
"be68e027220c9a1374fdaa352bf3401800536496"}

[commit-bot: I haz the power, 2016-11-22 23:19:23]

Description was changed from

==========
Call scrollbarsChanged in PLSA::updateAfterStyleChange.

This matches the call in updateAfterLayout (for auto scrollbars), and is needed
to ensure that LayoutBlockFlow::layoutBlockFlow sets relayoutChildren = true.

BUG=576304
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Call scrollbarsChanged in PLSA::updateAfterStyleChange.

This matches the call in updateAfterLayout (for auto scrollbars), and is needed
to ensure that LayoutBlockFlow::layoutBlockFlow sets relayoutChildren = true.

BUG=576304
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2016-11-22 23:19:24]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-11-22 23:23:06]

Description was changed from

==========
Call scrollbarsChanged in PLSA::updateAfterStyleChange.

This matches the call in updateAfterLayout (for auto scrollbars), and is needed
to ensure that LayoutBlockFlow::layoutBlockFlow sets relayoutChildren = true.

BUG=576304
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Call scrollbarsChanged in PLSA::updateAfterStyleChange.

This matches the call in updateAfterLayout (for auto scrollbars), and is needed
to ensure that LayoutBlockFlow::layoutBlockFlow sets relayoutChildren = true.

BUG=576304
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/4fc7dec0128b48b0f4d26d36e128a4d0c9d5d435
Cr-Commit-Position: refs/heads/master@{#434018}
==========

[commit-bot: I haz the power, 2016-11-22 23:23:07]

Patchset 3 (id:??) landed as
https://crrev.com/4fc7dec0128b48b0f4d26d36e128a4d0c9d5d435
Cr-Commit-Position: refs/heads/master@{#434018}