Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2523533002: Call scrollbarsChanged in PLSA::updateAfterStyleChange. (Closed)

Created:
4 years, 1 month ago by skobes
Modified:
4 years ago
Reviewers:
atotic
CC:
blink-reviews, blink-reviews-paint_chromium.org, cbiesinger, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call scrollbarsChanged in PLSA::updateAfterStyleChange. This matches the call in updateAfterLayout (for auto scrollbars), and is needed to ensure that LayoutBlockFlow::layoutBlockFlow sets relayoutChildren = true. BUG=576304 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/4fc7dec0128b48b0f4d26d36e128a4d0c9d5d435 Cr-Commit-Position: refs/heads/master@{#434018}

Patch Set 1 #

Total comments: 2

Patch Set 2 : check isLayoutBlock #

Patch Set 3 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -15 lines) Patch
A third_party/WebKit/LayoutTests/fast/scrolling/abspos-relayout-overflow-style-change.html View 1 chunk +71 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.cpp View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 2 4 chunks +19 lines, -8 lines 0 comments Download

Messages

Total messages: 33 (22 generated)
skobes
4 years, 1 month ago (2016-11-21 20:50:10 UTC) #10
atotic
https://codereview.chromium.org/2523533002/diff/20001/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp File third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp (right): https://codereview.chromium.org/2523533002/diff/20001/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp#newcode935 third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp:935: toLayoutBlock(box()).scrollbarsChanged(horizontalScrollbarChanged, box() can return null. Looking at existing code, ...
4 years, 1 month ago (2016-11-21 22:09:06 UTC) #11
skobes
https://codereview.chromium.org/2523533002/diff/20001/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp File third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp (right): https://codereview.chromium.org/2523533002/diff/20001/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp#newcode935 third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp:935: toLayoutBlock(box()).scrollbarsChanged(horizontalScrollbarChanged, On 2016/11/21 22:09:06, atotic2 wrote: > box() can ...
4 years, 1 month ago (2016-11-21 22:18:51 UTC) #14
atotic
lgtm
4 years, 1 month ago (2016-11-21 22:24:11 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523533002/40001
4 years, 1 month ago (2016-11-21 22:27:57 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/342069) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
4 years, 1 month ago (2016-11-21 23:56:40 UTC) #20
skobes
PTAL - updated to address failure in fast/table/overflowHidden.html. It looks like the intrinsic padding adjustments ...
4 years, 1 month ago (2016-11-22 04:32:01 UTC) #25
atotic
On 2016/11/22 at 04:32:01, skobes wrote: > PTAL - updated to address failure in fast/table/overflowHidden.html. ...
4 years ago (2016-11-22 23:01:20 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523533002/60001
4 years ago (2016-11-22 23:06:08 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years ago (2016-11-22 23:19:24 UTC) #31
commit-bot: I haz the power
4 years ago (2016-11-22 23:23:07 UTC) #33
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4fc7dec0128b48b0f4d26d36e128a4d0c9d5d435
Cr-Commit-Position: refs/heads/master@{#434018}

Powered by Google App Engine
This is Rietveld 408576698