Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 252353002: FCMify text-based-repaint layout tests (Closed)

Created:
6 years, 8 months ago by enne (OOO)
Modified:
6 years, 8 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, dsinclair, danakj, ojan
Visibility:
Public.

Description

FCMify text-based-repaint layout tests Repaint tracking happens in both FrameView and GraphicsLayer. When layout tests are always composited, then FrameView no longer tracks repaints and they are all collected on GraphicsLayer. The text-based-repaint.js test is adjusted to print out the graphics layer tree and to force any test using it into FCM. In order to print out repaint rects, the layer tree has to be printed out instead. I looked through all the results and the only differences are that repaints are now clipped to not extend into negative space and that repaints are relative to the graphics layer and not the viewport (so are differently offset by scrolling). The vast majority of these are text changes, but there are 4 image changes in svg, that are all using "text"-based-repaint to do pixel repaint tests. These are all scrollbar differences similar to https://codereview.chromium.org/249963002/ and one imperceptible image scaling change. A follow up to this would be to remove the FrameView-based repaint tracking plumbing and only use the GraphicsLayer-based version. BUG=361729 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172545

Patch Set 1 #

Patch Set 2 : Expectations #

Total comments: 1

Patch Set 3 : Mac expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+671 lines, -2 lines) Patch
M LayoutTests/TestExpectations View 1 2 2 chunks +664 lines, -1 line 0 comments Download
M LayoutTests/fast/repaint/resources/text-based-repaint.js View 2 chunks +3 lines, -1 line 0 comments Download
M LayoutTests/svg/as-image/set-img-height-expected.html View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
enne (OOO)
https://codereview.chromium.org/252353002/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (left): https://codereview.chromium.org/252353002/diff/20001/LayoutTests/TestExpectations#oldcode1042 LayoutTests/TestExpectations:1042: crbug.com/362050 [ Retina ] fast/repaint/block-layout-inline-children-replaced.html [ Failure ] This ...
6 years, 8 months ago (2014-04-23 23:56:55 UTC) #1
abarth-chromium
lgtm
6 years, 8 months ago (2014-04-24 14:41:39 UTC) #2
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 8 months ago (2014-04-24 14:41:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/252353002/20001
6 years, 8 months ago (2014-04-24 14:42:13 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 15:16:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 8 months ago (2014-04-24 15:16:47 UTC) #6
enne (OOO)
The Mac has a bunch of pixel differences (e.g. one bit in alpha or color) ...
6 years, 8 months ago (2014-04-24 18:31:43 UTC) #7
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 8 months ago (2014-04-24 18:31:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/252353002/40001
6 years, 8 months ago (2014-04-24 18:32:18 UTC) #9
commit-bot: I haz the power
Change committed as 172545
6 years, 8 months ago (2014-04-24 22:59:01 UTC) #10
enne (OOO)
6 years, 8 months ago (2014-04-25 22:26:37 UTC) #11
Message was sent while issue was closed.
Reverted in http://src.chromium.org/viewvc/blink?view=revision&revision=172675

Powered by Google App Engine
This is Rietveld 408576698