DescriptionFCMify text-based-repaint layout tests
Repaint tracking happens in both FrameView and GraphicsLayer. When
layout tests are always composited, then FrameView no longer tracks
repaints and they are all collected on GraphicsLayer. The
text-based-repaint.js test is adjusted to print out the graphics
layer tree and to force any test using it into FCM.
In order to print out repaint rects, the layer tree has to be printed
out instead. I looked through all the results and the only differences
are that repaints are now clipped to not extend into negative space and
that repaints are relative to the graphics layer and not the viewport
(so are differently offset by scrolling).
The vast majority of these are text changes, but there are 4 image
changes in svg, that are all using "text"-based-repaint to do pixel
repaint tests. These are all scrollbar differences similar to
https://codereview.chromium.org/249963002/ and one imperceptible
image scaling change.
A follow up to this would be to remove the FrameView-based repaint
tracking plumbing and only use the GraphicsLayer-based version.
BUG=361729
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172545
Patch Set 1 #Patch Set 2 : Expectations #
Total comments: 1
Patch Set 3 : Mac expectations #
Messages
Total messages: 11 (0 generated)
|