Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2523523002: Add ink drop ripple to status tray (Closed)

Created:
4 years ago by mohsen
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Add ink drop ripple to status tray This is still not handling view resizes that happen when an ink drop is active (e.g., in status tray). A workaround is implemented, but proper fix would need a follow-up CL. This CL also changes round rect mask to take insets instead of bounds so that there would be no need to update mask bounds when size of host view is updated. BUG=612544 TEST=manual Review-Url: https://codereview.chromium.org/2510603003 Cr-Commit-Position: refs/heads/master@{#433113} (cherry picked from commit c109436f07a06f711d50c982e2284f1460abd8a9)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -34 lines) Patch
M ash/common/system/tray/system_tray.cc View 1 chunk +6 lines, -1 line 0 comments Download
M ash/common/system/tray/tray_background_view.h View 2 chunks +8 lines, -0 lines 0 comments Download
M ash/common/system/tray/tray_background_view.cc View 5 chunks +58 lines, -20 lines 0 comments Download
M ash/common/system/tray/tray_popup_utils.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/common/system/tray/tray_popup_utils.cc View 2 chunks +19 lines, -7 lines 0 comments Download
M ash/common/system/user/tray_user.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/animation/ink_drop_host_view.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/animation/ink_drop_mask.h View 3 chunks +10 lines, -3 lines 0 comments Download
M ui/views/animation/ink_drop_mask.cc View 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
mohsen
4 years ago (2016-11-21 20:47:09 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) to pending queue manually as
2fd548fc750d0cade0738f9747ad255ce89d8a45.

Powered by Google App Engine
This is Rietveld 408576698