Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2523513002:
Simplify ImageDocument checkerboard background styling (Closed)
DescriptionSimplify ImageDocument checkerboard background styling
We're currently generating the checkerboard using three background
layers:
* solid white color
* 2x semi-transparent gradients
The same effect can be achieved without the solid color layer, by
adjusting the bottom gradient colors.
R=pdr@chromium.org, dfalcantara@chromium.org
Committed: https://crrev.com/69b378ee170bc440f44d5a34c9eb322d23189d66
Cr-Commit-Position: refs/heads/master@{#433767}
Patch Set 1 #Patch Set 2 : expectations #Patch Set 3 : formatting #
Total comments: 2
Patch Set 4 : typos #
Messages
Total messages: 23 (16 generated)
The CQ bit was checked by fmalita@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fmalita@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by fmalita@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
A handful of text diffs only: https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r... I also verified manually that the checkerboard pattern for https://pr.gg/happy.png looks right.
I tried this when reviewing the first patch, but was changing both "transparent" colors which didn't work. Clever solution just changing the second gradient's. LGTM Please wait for dfalcantara to review this as well.
Couple of typos, but lgtm. Thanks! https://codereview.chromium.org/2523513002/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/html/ImageDocument.cpp (right): https://codereview.chromium.org/2523513002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/html/ImageDocument.cpp:421: // Generating the checkerboard pattern this was is not exactly cheap. was -> way and -> an
https://codereview.chromium.org/2523513002/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/html/ImageDocument.cpp (right): https://codereview.chromium.org/2523513002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/html/ImageDocument.cpp:421: // Generating the checkerboard pattern this was is not exactly cheap. On 2016/11/22 01:28:30, dfalcantara (check my queue) wrote: > was -> way > and -> an Done.
The CQ bit was checked by fmalita@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org, dfalcantara@chromium.org Link to the patchset: https://codereview.chromium.org/2523513002/#ps60001 (title: "typos")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1479779064155180,
"parent_rev": "e8e0ea375de9ea15b15779fa46ba5d6759851406", "commit_rev":
"b085a44046ffc2424840bd8eb0c7ad2139e26612"}
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Simplify ImageDocument checkerboard background styling We're currently generating the checkerboard using three background layers: * solid white color * 2x semi-transparent gradients The same effect can be achieved without the solid color layer, by adjusting the bottom gradient colors. R=pdr@chromium.org, dfalcantara@chromium.org ========== to ========== Simplify ImageDocument checkerboard background styling We're currently generating the checkerboard using three background layers: * solid white color * 2x semi-transparent gradients The same effect can be achieved without the solid color layer, by adjusting the bottom gradient colors. R=pdr@chromium.org, dfalcantara@chromium.org Committed: https://crrev.com/69b378ee170bc440f44d5a34c9eb322d23189d66 Cr-Commit-Position: refs/heads/master@{#433767} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/69b378ee170bc440f44d5a34c9eb322d23189d66 Cr-Commit-Position: refs/heads/master@{#433767} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
