Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 25235002: When visiting arguments in the resolver, always set the [sendIsPropertyAccess] to false. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/issue13673_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/resolution/members.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/resolution/members.dart (revision 28036)
+++ sdk/lib/_internal/compiler/implementation/resolution/members.dart (working copy)
@@ -2341,6 +2341,8 @@
void resolveArguments(NodeList list) {
if (list == null) return;
+ bool oldSendIsMemberAccess = sendIsMemberAccess;
+ sendIsMemberAccess = false;
Map<SourceString, Node> seenNamedArguments = new Map<SourceString, Node>();
for (Link<Node> link = list.nodes; !link.isEmpty; link = link.tail) {
Expression argument = link.head;
@@ -2360,6 +2362,7 @@
error(argument, MessageKind.INVALID_ARGUMENT_AFTER_NAMED);
}
}
+ sendIsMemberAccess = oldSendIsMemberAccess;
}
visitSend(Send node) {
@@ -2424,10 +2427,7 @@
}
if (!resolvedArguments) {
- oldSendIsMemberAccess = sendIsMemberAccess;
- sendIsMemberAccess = false;
resolveArguments(node.argumentsNode);
- sendIsMemberAccess = oldSendIsMemberAccess;
}
// If the selector is null, it means that we will not be generating
« no previous file with comments | « no previous file | tests/language/issue13673_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698