Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3233)

Unified Diff: chrome/browser/resources/settings/languages_page/languages_page.html

Issue 2523403003: Language settings: fix focus issues (Closed)
Patch Set: fixes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/languages_page/languages_page.html
diff --git a/chrome/browser/resources/settings/languages_page/languages_page.html b/chrome/browser/resources/settings/languages_page/languages_page.html
index 5e7314a1c8a30dae468f586d7040634dbcdc98bf..4dfa76ccf2e6300f7b4fde592a461f5a0bf3c625 100644
--- a/chrome/browser/resources/settings/languages_page/languages_page.html
+++ b/chrome/browser/resources/settings/languages_page/languages_page.html
@@ -1,3 +1,4 @@
+<link rel="import" href="chrome://resources/html/action_link.html">
<link rel="import" href="chrome://resources/html/assert.html">
<link rel="import" href="chrome://resources/html/cr.html">
<link rel="import" href="chrome://resources/html/polymer.html">
@@ -70,7 +71,8 @@
</settings-languages>
<settings-animated-pages id="pages" section="languages">
<neon-animatable route-path="default">
- <div class$="settings-box first [[getLanguageListTwoLine_()]]">
+ <div class$="settings-box first [[getLanguageListTwoLine_()]]"
+ actionable on-tap="toggleExpandButton_">
<div class="start">
<div>$i18n{languagesListTitle}</div>
<if expr="chromeos or is_win">
@@ -123,13 +125,14 @@
</div>
</template>
<div class="list-item list-button" on-tap="onAddLanguagesTap_">
- $i18n{addLanguages}
+ <a is="action-link">$i18n{addLanguages}</a>
</div>
</div>
</iron-collapse>
<if expr="chromeos">
<div id="manage-input-methods-subpage-trigger"
- class="settings-box two-line">
+ class="settings-box two-line" actionable
+ on-tap="toggleExpandButton_">
<div class="start">
<div>$i18n{inputMethodsListTitle}</div>
<div class="secondary">
@@ -147,7 +150,8 @@
items="[[languages.inputMethods.enabled]]">
<div class$="list-item [[getInputMethodItemClass_(
item.id, languages.inputMethods.currentId)]]"
- on-tap="onInputMethodTap_" actionable>
+ on-tap="onInputMethodTap_" on-keypress="onInputMethodTap_"
+ actionable tabindex="0">
<div class="start">
<div>[[item.displayName]]</div>
<div class="explain-selected"
@@ -164,13 +168,16 @@
</template>
<div class="list-item list-button"
on-tap="onManageInputMethodsTap_">
- $i18n{manageInputMethods}
+ <a is="action-link">$i18n{manageInputMethods}</a>
</div>
</div>
</iron-collapse>
</if>
<if expr="not is_macosx">
- <div id="spellcheck-subpage-trigger" class="settings-box two-line">
+ <div id="spellcheck-subpage-trigger"
+ class$="settings-box [[getSpellcheckListTwoLine_(
michaelpg 2016/12/01 23:19:13 Note this additional change... originally I didn't
+ languages.enabled.*)]]"
+ actionable on-tap="toggleExpandButton_">
<div class="start">
<div>$i18n{spellCheckListTitle}</div>
<div class="secondary">
@@ -194,7 +201,7 @@
</label>
</template>
<div class="list-item list-button" on-tap="onEditDictionaryTap_">
- $i18n{manageSpellCheck}
+ <a is="action-link">$i18n{manageSpellCheck}</a>
</div>
</div>
</iron-collapse>

Powered by Google App Engine
This is Rietveld 408576698