Language settings: fix focus issues

chrome/browser/resources/settings/languages_page/languages_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'settings-languages-page' is the settings page
  * for language and input method settings.
  */
 (function() {
 'use strict';
@@ skipping 258 matching lines @@
   /**
    * Opens the Manage Input Methods page.
    * @private
    */
   onManageInputMethodsTap_: function() {
     assert(cr.isChromeOS);
     settings.navigateTo(settings.Route.INPUT_METHODS);
   },
 
   /**
-   * Handler for clicking an input method on the main page, which sets it as
-   * the current input method.
+   * Handler for tap and <Enter> events on an input method on the main page,
+   * which sets it as the current input method.
    * @param {!{model: !{item: !chrome.languageSettingsPrivate.InputMethod},
-   *           target: !{tagName: string}}} e
+   *           target: !{tagName: string},
+   *           type: string,
+   *           key: (string|undefined)}} e
    */
   onInputMethodTap_: function(e) {
     assert(cr.isChromeOS);
 
     // Taps on the paper-icon-button are handled in onInputMethodOptionsTap_.
     if (e.target.tagName == 'PAPER-ICON-BUTTON')
       return;
 
+    // Ignore key presses other than <Enter>.
+    if (e.type == 'keypress' && e.key != 'Enter')
+      return;
+
     // Set the input method.
     this.languageHelper.setCurrentInputMethod(e.model.item.id);
   },
 
   /**
    * Opens the input method extension's options page in a new tab (or focuses
    * an existing instance of the IME's options).
    * @param {!{model: !{item: chrome.languageSettingsPrivate.InputMethod}}} e
    * @private
    */
@@ skipping 191 matching lines @@
    * @private
    */
   onRestartTap_: function() {
 <if expr="chromeos">
     settings.LifetimeBrowserProxyImpl.getInstance().signOutAndRestart();
 </if>
 <if expr="not chromeos">
     settings.LifetimeBrowserProxyImpl.getInstance().restart();
 </if>
   },
+
+  /**
+   * Toggles the expand button within the element being listened to.
+   * @param {!Event} e
+   * @private
+   */
+  toggleExpandButton_: function(e) {
+    // The expand button handles toggling itself.
+    var expandButtonTag = 'CR-EXPAND-BUTTON';
+    if (e.target.tagName == expandButtonTag)
+      return;
+
+    /** @type {!CrExpandButtonElement} */
+    var expandButton = e.currentTarget.querySelector(expandButtonTag);

[stevenjb, 2016/11/28 17:49:16]

nit: 'var expandButton =' on prev line?

[michaelpg, 2016/12/01 23:19:13]

meh... i find that less readable. @type above var is more consistent with other
typing (prototype property types and normal typedefs), whereas inline @type is
normally used as a cast.

also, it doesn't seem to be very common at least in settings... by which i mean,
it's only in code that you write :-P unless my search is wrong:
https://cs.chromium.org/search/?q=file:resources%5C/settings+%5E%5Cs*%5C/%5C*...

[stevenjb, 2016/12/01 23:45:33]

*shrug*

+    assert(expandButton);
+    expandButton.expanded = !expandButton.expanded;
+  },
 });
 })();