Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2523403002: Fix initial USB enumeration on Linux to return all devices. (Closed)

Created:
4 years ago by Reilly Grant (use Gerrit)
Modified:
4 years ago
Reviewers:
juncai
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix initial USB enumeration on Linux to return all devices. This patch fixes an issue where the first enumeration of USB devices on Linux would only return a single device and observers would not be notified of additional devices. This was because the logic to determine if enumeration callbacks should be called was checking only that all previously seen devices (of which there was only one at that point) were ready and not that the sysfs tree had been completely walked. BUG=662486 Committed: https://crrev.com/5c30282c70ec5f7f92129589fbbc84fef5738454 Cr-Commit-Position: refs/heads/master@{#434718}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M device/usb/usb_service_linux.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years ago (2016-11-24 01:03:40 UTC) #2
juncai
LGTM.
4 years ago (2016-11-28 18:42:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523403002/1
4 years ago (2016-11-28 19:08:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 21:07:09 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-28 21:10:22 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c30282c70ec5f7f92129589fbbc84fef5738454
Cr-Commit-Position: refs/heads/master@{#434718}

Powered by Google App Engine
This is Rietveld 408576698