Chromium Code Reviews| Index: content/browser/byte_stream.cc |
| diff --git a/content/browser/byte_stream.cc b/content/browser/byte_stream.cc |
| index 1c70739a9f4171f248d87f1b4d0c322f7ad0fd39..a0fb11dc40ae6fd400ea873bffcd8f194e86b84f 100644 |
| --- a/content/browser/byte_stream.cc |
| +++ b/content/browser/byte_stream.cc |
| @@ -22,15 +22,15 @@ ContentVector; |
| class ByteStreamReaderImpl; |
| -// A poor man's weak pointer; a RefCountedThreadSafe boolean that can be |
| -// cleared in an object destructor and accessed to check for object |
| -// existence. We can't use weak pointers because they're tightly tied to |
| -// threads rather than task runners. |
| -// TODO(rdsmith): A better solution would be extending weak pointers |
| -// to support SequencedTaskRunners. |
| +// A makeshift weak pointer; a RefCountedThreadSafe boolean that can be cleared |
| +// in an object destructor and accessed to check for object existence. We can't |
| +// use weak pointers because they're tightly tied to threads rather than task |
| +// runners. |
| +// TODO(rdsmith): A better solution would be extending weak pointers to support |
|
Matt Giuca
2016/11/28 00:10:41
nit: Wrap "to support" onto the next line (no need
meredithl
2016/11/28 00:35:49
Acknowledged.
meredithl
2016/11/28 00:48:08
Done.
|
| +// SequencedTaskRunners. |
| struct LifetimeFlag : public base::RefCountedThreadSafe<LifetimeFlag> { |
| public: |
| - LifetimeFlag() : is_alive(true) { } |
| + LifetimeFlag() : is_alive(true) {} |
| bool is_alive; |
| protected: |