Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1763)

Unified Diff: appengine/findit/model/crash/test/fracas_crash_analysis_test.py

Issue 2523343002: [Predator] Refactor ToPublishResult and fix keyerror 'found' (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/model/crash/test/fracas_crash_analysis_test.py
diff --git a/appengine/findit/model/crash/test/fracas_crash_analysis_test.py b/appengine/findit/model/crash/test/fracas_crash_analysis_test.py
index 6cf95baa1a622b972a35a6565759aadf9f2a2e9e..888a649626588e352dce2c15eed455fe0fccb5c5 100644
--- a/appengine/findit/model/crash/test/fracas_crash_analysis_test.py
+++ b/appengine/findit/model/crash/test/fracas_crash_analysis_test.py
@@ -3,11 +3,12 @@
# found in the LICENSE file.
from datetime import datetime
+import mock
from crash.test.crash_testcase import CrashTestCase
from model import analysis_status
from model import result_status
-from model.crash.fracas_crash_analysis import FracasCrashAnalysis
+from model.crash import fracas_crash_analysis
class FracasCrashAnalysisTest(CrashTestCase):
@@ -20,9 +21,29 @@ class FracasCrashAnalysisTest(CrashTestCase):
'platform': 'win',
'process_type': 'browser',
}
- FracasCrashAnalysis.Create(crash_identifiers).put()
- analysis = FracasCrashAnalysis.Get(crash_identifiers)
+ fracas_crash_analysis.FracasCrashAnalysis.Create(crash_identifiers).put()
+ analysis = fracas_crash_analysis.FracasCrashAnalysis.Get(crash_identifiers)
self.assertIsNone(analysis.crashed_version)
self.assertIsNone(analysis.signature)
self.assertIsNone(analysis.channel)
self.assertIsNone(analysis.platform)
+
+ @mock.patch('google.appengine.ext.ndb.Key.urlsafe')
+ @mock.patch('common.appengine_util.GetDefaultVersionHostname')
+ def testProcessResultForPublishing(self, mocked_get_default_host,
+ mocked_urlsafe):
+ mocked_host = 'http://host'
+ mocked_get_default_host.return_value = mocked_host
+ urlsafe_key = 'abcde'
+ mocked_urlsafe.return_value = urlsafe_key
+
+ analysis = fracas_crash_analysis.FracasCrashAnalysis.Create(
+ {'signature': 'sig'})
+ result = {'other': 'data'}
+ expected_processed_result = {
+ 'other': 'data',
+ 'feedback_url': fracas_crash_analysis.FRACAS_FEEDBACK_URL_TEMPLATE % (
+ mocked_host, urlsafe_key)
+ }
+ self.assertDictEqual(analysis.ProcessResultForPublishing(result),
+ expected_processed_result)

Powered by Google App Engine
This is Rietveld 408576698