appengine/findit/crash/crash_pipeline.py - Issue 2523343002: [Predator] Refactor ToPublishResult and fix keyerror 'found'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/crash/crash_pipeline.py

Issue 2523343002: [Predator] Refactor ToPublishResult and fix keyerror 'found' (Closed)

Patch Set: . Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/findit/crash/crash_pipeline.py

diff --git a/appengine/findit/crash/crash_pipeline.py b/appengine/findit/crash/crash_pipeline.py

index ae34261631005d0cc45a5874aea7f59ca55a735e..57eb151ff27a9ed3241ce50e9a6f2e0742bae4dd 100644

--- a/appengine/findit/crash/crash_pipeline.py

+++ b/appengine/findit/crash/crash_pipeline.py

@@ -179,7 +179,7 @@ class PublishResultPipeline(CrashBasePipeline):

(except for ``self``, naturally).

"""

analysis = self._findit.GetAnalysis(self._crash_identifiers)

- if analysis.failed:

+ if analysis.failed or not analysis.result:

logging.info('Can\'t publish result to %s because analysis failed:\n%s',

self.client_id, repr(self._crash_identifiers))

return