Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2127)

Unified Diff: appengine/findit/crash/crash_pipeline.py

Issue 2523343002: [Predator] Refactor ToPublishResult and fix keyerror 'found' (Closed)
Patch Set: Rebase. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/findit/crash/findit.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/crash_pipeline.py
diff --git a/appengine/findit/crash/crash_pipeline.py b/appengine/findit/crash/crash_pipeline.py
index 897f0d3b4ccc7b2bef3952f565979f09240b5f8c..fcf4334689a8d239c6a9a842ccde48ee44407eae 100644
--- a/appengine/findit/crash/crash_pipeline.py
+++ b/appengine/findit/crash/crash_pipeline.py
@@ -187,12 +187,13 @@ class PublishResultPipeline(CrashBasePipeline):
(except for ``self``, naturally).
"""
analysis = self._findit.GetAnalysis(self._crash_identifiers)
- if analysis.failed:
+ if not analysis or not analysis.result or analysis.failed:
logging.info('Can\'t publish result to %s because analysis failed:\n%s',
self.client_id, repr(self._crash_identifiers))
return
- result = analysis.ToPublishableResult(self._crash_identifiers)
+ result = self._findit.GetPublishableResult(self._crash_identifiers,
+ analysis)
messages_data = [json.dumps(result, sort_keys=True)]
# TODO(http://crbug.com/659354): remove Findit's dependency on CrashConfig.
« no previous file with comments | « no previous file | appengine/findit/crash/findit.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698