[Predator] Refactor ToPublishResult and fix keyerror 'found'

appengine/findit/crash/test/findit_for_chromecrash_test.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import mock
+
 from common import chrome_dependency_fetcher
 from common.dependency import DependencyRoll
 from common.http_client_appengine import HttpClientAppengine
 from crash import chromecrash_parser
 from crash import detect_regression_range
+from crash import findit
 from crash import findit_for_chromecrash
 from crash.changelist_classifier import ChangelistClassifier
 from crash.chromecrash_parser import ChromeCrashParser
 from crash.component_classifier import ComponentClassifier
 from crash.crash_report import CrashReport
 from crash.culprit import Culprit
 from crash.findit_for_chromecrash import FinditForChromeCrash
 from crash.findit_for_chromecrash import FinditForFracas
-from crash.findit import Findit
 from crash.project_classifier import ProjectClassifier
 from crash.results import MatchResult
 from crash.stacktrace import CallStack
 from crash.stacktrace import Stacktrace
 from crash.test.crash_pipeline_test import DummyCrashData
 from crash.test.crash_testcase import CrashTestCase
 from crash.type_enums import CrashClient
 from lib.gitiles import gitiles_repository
 from model import analysis_status
 from model.crash.crash_analysis import CrashAnalysis
 from model.crash.fracas_crash_analysis import FracasCrashAnalysis
 
 MOCK_REPOSITORY = None
 
-class _FinditForChromeCrash(FinditForChromeCrash):
+class _FinditForChromeCrash(FinditForChromeCrash):  # pylint: disable = W
   # We allow overriding the default MOCK_REPOSITORY because one unittest
   # needs to.
   def __init__(self, repository=MOCK_REPOSITORY):
     super(_FinditForChromeCrash, self).__init__(repository)
 
   @classmethod
   def _ClientID(cls): # pragma: no cover
     """Avoid throwing a NotImplementedError.
 
     Since this method is called from ``FinditForChromeCrash.__init__``
@@ skipping 10 matching lines @@
     The default ``Findit.config`` will return None if the client
     id is not found in the CrashConfig. This in turn will cause
     ``FinditForChromeCrash.__init__`` to crash, since NoneType doesn't
     have a ``get`` method. In general it's fine for things to crash, since
     noone should make instances of Findit subclasses which don't define
     ``_clientID``; but for this test suite, we want to permit instances
     of FinditForChromeCrash, so that we can test that class directly.
     """
     return {}
 
+
 def _FinditForFracas():
   """A helper to pass in the standard pipeline class."""
   return FinditForFracas(MOCK_REPOSITORY)
 
 
 class FinditForChromeCrashTest(CrashTestCase):
 
   chrome_dep_fetcher = chrome_dependency_fetcher.ChromeDependencyFetcher(
       gitiles_repository.GitilesRepository(HttpClientAppengine()))
 
@@ skipping 178 matching lines @@
     expected_tag = {
           'found_suspects': False,
           'found_project': False,
           'found_components': False,
           'has_regression_range': False,
           'solution': 'core_algorithm',
     }
 
     self.assertDictEqual(expected_results, results)
     self.assertDictEqual(expected_tag, tag)
+
+  @mock.patch('google.appengine.ext.ndb.Key.urlsafe')
+  @mock.patch('common.appengine_util.GetDefaultVersionHostname')
+  def testProcessResultForPublishing(self, mocked_get_default_host,
+                                     mocked_urlsafe):
+    mocked_host = 'http://host'
+    mocked_get_default_host.return_value = mocked_host
+    urlsafe_key = 'abcde'
+    mocked_urlsafe.return_value = urlsafe_key
+
+    crash_identifiers = {'signature': 'sig'}
+    analysis = FracasCrashAnalysis.Create(crash_identifiers)
+    analysis.result = {'other': 'data'}
+    findit_object = FinditForFracas(None)
+    expected_processed_result = {
+        'client_id': findit_object.client_id,
+        'crash_identifiers': {'signature': 'sig'},
+        'result': {
+            'feedback_url': (
+                findit_for_chromecrash._FRACAS_FEEDBACK_URL_TEMPLATE % (
+                    mocked_host, urlsafe_key)),
+            'other': 'data'
+        }
+    }
+
+    self.assertDictEqual(findit_object.GetPublishableResult(crash_identifiers,
+                                                            analysis),
+                         expected_processed_result)