[Predator] Refactor ToPublishResult and fix keyerror 'found'

appengine/findit/crash/findit_for_chromecrash.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 
 from google.appengine.ext import ndb
 
+from common import appengine_util
 from crash import detect_regression_range
 from crash.changelist_classifier import ChangelistClassifier
 from crash.chromecrash_parser import ChromeCrashParser
 from crash.component_classifier import Component
 from crash.component_classifier import ComponentClassifier
 from crash.findit import Findit
 from crash.predator import Predator
 from crash.project_classifier import ProjectClassifier
 from crash.type_enums import CrashClient
 from model.crash.cracas_crash_analysis import CracasCrashAnalysis
 from model.crash.crash_config import CrashConfig
 from model.crash.fracas_crash_analysis import FracasCrashAnalysis
 
 # TODO(katesonia): Remove the default value after adding validity check to
 # config.
 _DEFAULT_TOP_N = 7
-
+_FRACAS_FEEDBACK_URL_TEMPLATE = '%s/crash/fracas-result-feedback?key=%s'
 
 # TODO(wrengr): [Note#1] in many places below we have to do some ugly
 # defaulting in case crash_data is missing certain keys. If we had
 # crash_data be a proper class, rather than an anonymous dict, then we
 # could clean all this up by having the properties themselves do the check
 # and return the default whenever keys are missing. This would also
 # let us do things like have regression_range be automatically computed
 # from historical_metadata (when historical_metadata is provided and
 # regression_range is not).
 
@@ skipping 86 matching lines @@
       if blacklist_marker in signature:
         logging.info('%s signature is not supported. '
                      'No analysis is scheduled for %s', blacklist_marker,
                      repr(crash_identifiers))
         return None
 
     # TODO(wrengr): should we clone ``crash_data`` rather than mutating it?
     crash_data['platform'] = self.RenamePlatform(platform)
     return crash_data
 
+  def ProcessResultForPublishing(self, result, key):  # pragma: no cover.
+    """Client specific processing of result data for publishing."""
+    # This method needs to get overwritten by subclasses FinditForCracas and
+    # FinditForFracas.
+    raise NotImplementedError()
+
 
 # TODO(http://crbug.com/659346): we misplaced the coverage tests; find them!
 class FinditForCracas(FinditForChromeCrash): # pragma: no cover
   @classmethod
   def _ClientID(cls):
     return CrashClient.CRACAS
 
   def CreateAnalysis(self, crash_identifiers):
     # TODO: inline CracasCrashAnalysis.Create stuff here.
     return CracasCrashAnalysis.Create(crash_identifiers)
 
   def GetAnalysis(self, crash_identifiers):
     # TODO: inline CracasCrashAnalysis.Get stuff here.
     return CracasCrashAnalysis.Get(crash_identifiers)
 
+  def ProcessResultForPublishing(self, result, key):  # pragma: no cover.
+    """Cracas specific processing of result data for publishing."""
+    # TODO(katesonia) Add feedback page link information to result after
+    # feedback page of Cracas is added.
+    return result
+
 
 class FinditForFracas(FinditForChromeCrash):
   @classmethod
   def _ClientID(cls):
     return CrashClient.FRACAS
 
   def CreateAnalysis(self, crash_identifiers):
     # TODO: inline FracasCrashAnalysis.Create stuff here.
     return FracasCrashAnalysis.Create(crash_identifiers)
 
   def GetAnalysis(self, crash_identifiers):
     # TODO: inline FracasCrashAnalysis.Get stuff here.
     return FracasCrashAnalysis.Get(crash_identifiers)
+
+  def ProcessResultForPublishing(self, result, key):
+    """Fracas specific processing of result data for publishing."""
+    result['feedback_url'] = _FRACAS_FEEDBACK_URL_TEMPLATE % (
+        appengine_util.GetDefaultVersionHostname(), key)
+    return result