Use GPRs for mints

runtime/vm/locations.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/locations.h"
 
 #include "vm/assembler.h"
 #include "vm/il_printer.h"
 #include "vm/intermediate_language.h"
 #include "vm/flow_graph_compiler.h"
@@ skipping 192 matching lines @@
 }
 
 
 void Location::PrintTo(BufferFormatter* f) const {
   if (kind() == kStackSlot) {
     f->Print("S%+" Pd "", stack_index());
   } else if (kind() == kDoubleStackSlot) {
     f->Print("DS%+" Pd "", stack_index());
   } else if (kind() == kQuadStackSlot) {
     f->Print("QS%+" Pd "", stack_index());
+  } else if (IsPairLocation()) {
+    f->Print("(");
+    AsPairLocation()->At(0).PrintTo(f);
+    f->Print(", ");
+    AsPairLocation()->At(1).PrintTo(f);
+    f->Print(")");
   } else {
     f->Print("%s", Name());
   }
 }
 
 
 const char* Location::ToCString() const {
   char buffer[1024];
   BufferFormatter bf(buffer, 1024);
   PrintTo(&bf);
   return Isolate::Current()->current_zone()->MakeCopyOfString(buffer);
 }
 
 
 void Location::Print() const {
   if (kind() == kStackSlot) {
     OS::Print("S%+" Pd "", stack_index());
   } else {
     OS::Print("%s", Name());
   }
 }
 
 
+Location Location::Copy() const {
+  if (IsPairLocation()) {
+    PairLocation* pair = AsPairLocation();
+    ASSERT(!pair->At(0).IsPairLocation());
+    ASSERT(!pair->At(1).IsPairLocation());
+    return Location::Pair(pair->At(0), pair->At(1));

[Florian Schneider, 2014/04/30 18:55:46]

I think here you should do a deep copy of the parts as well. Otherwise there
will be unintended sharing of the location parts.

[Cutch, 2014/05/14 17:16:19]

Done.

+  } else {
+    // Copy by value.
+    return *this;
+  }
+}
+
+
 void LocationSummary::PrintTo(BufferFormatter* f) const {
   if (input_count() > 0) {
     f->Print(" (");
     for (intptr_t i = 0; i < input_count(); i++) {
       if (i != 0) f->Print(", ");
       in(i).PrintTo(f);
     }
     f->Print(")");
   }
 
   if (temp_count() > 0) {
     f->Print(" [");
     for (intptr_t i = 0; i < temp_count(); i++) {
       if (i != 0) f->Print(", ");
       temp(i).PrintTo(f);
     }
     f->Print("]");
   }
 
   if (!out(0).IsInvalid()) {
     f->Print(" => ");
     out(0).PrintTo(f);
   }
 
   if (always_calls()) f->Print(" C");
 }
 
 }  // namespace dart