Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 2523313002: Fix the setting of analysis options when there is an embedded SDK (Closed)

Created:
4 years ago by Brian Wilkerson
Modified:
4 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix the setting of analysis options when there is an embedded SDK R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/5b1236cfe75bd30fa36a2889fed00e67923995fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/analyzer_cli/lib/src/driver.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years ago (2016-11-23 21:26:30 UTC) #2
scheglov
lgtm
4 years ago (2016-11-23 23:45:49 UTC) #3
Brian Wilkerson
4 years ago (2016-11-23 23:48:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5b1236cfe75bd30fa36a2889fed00e67923995fd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698