Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: test/cctest/heap/test-spaces.cc

Issue 2523293002: PPC64: Changing test-spaces/SizeOfInitialHeap to accomodate 64K page size (Closed)
Patch Set: Making suggested changes (changing expected max size of initial heap). Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/heap/test-spaces.cc
diff --git a/test/cctest/heap/test-spaces.cc b/test/cctest/heap/test-spaces.cc
index 9a7585d68180dd2269cce67000747f1d723574eb..fc692e331c3b1b4b6b2895493f54292d442c3539 100644
--- a/test/cctest/heap/test-spaces.cc
+++ b/test/cctest/heap/test-spaces.cc
@@ -503,9 +503,15 @@ TEST(SizeOfInitialHeap) {
// Initial size of LO_SPACE
size_t initial_lo_space = isolate->heap()->lo_space()->Size();
- // The limit for each space for an empty isolate containing just the
- // snapshot.
+// The limit for each space for an empty isolate containing just the
+// snapshot.
+// In PPC the page size is 64K, causing more internal fragmentation
+// hence requiring a larger limit.
+#if V8_OS_LINUX && V8_HOST_ARCH_PPC
+ const size_t kMaxInitialSizePerSpace = 3 * MB;
+#else
const size_t kMaxInitialSizePerSpace = 2 * MB;
+#endif
// Freshly initialized VM gets by with the snapshot size (which is below
// kMaxInitialSizePerSpace per space).
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698