PPC64: Changing test-spaces/SizeOfInitialHeap to accomodate 64K page size

test/cctest/heap/test-spaces.cc

Index: test/cctest/heap/test-spaces.cc
diff --git a/test/cctest/heap/test-spaces.cc b/test/cctest/heap/test-spaces.cc
index 9a7585d68180dd2269cce67000747f1d723574eb..696aef23e1b6d0012386ad6e47c1b8ce49bfacc5 100644
--- a/test/cctest/heap/test-spaces.cc
+++ b/test/cctest/heap/test-spaces.cc
@@ -517,7 +517,14 @@ TEST(SizeOfInitialHeap) {
 
     page_count[i] = heap->paged_space(i)->CountTotalPages();
     // Check that the initial heap is also below the limit.
+// In PPC the page size is 64K, hence no memory will be freed causing
+// the initial committed memory in code spaces to be exactly 2M.
+// changing the test case to accomodate this.
+#if V8_OS_LINUX && V8_HOST_ARCH_PPC
+    CHECK_LE(heap->paged_space(i)->CommittedMemory(), kMaxInitialSizePerSpace);

[Michael Lippautz, 2016/11/25 15:23:51]

I would put the #define_s around kMaxInitialSizePerSpace above and just make it
slightly larger. This constant is arbitrary and should just help us in
recognizing any regressions.

Also, there's no memory being freed here as we do these checks right after
deserialization. So I would write something along the lines of "For 64k pages we
have more fragmentation and need a larger limit."

+#else
     CHECK_LT(heap->paged_space(i)->CommittedMemory(), kMaxInitialSizePerSpace);
+#endif
   }
 
   // Executing the empty script gets by with the same number of pages, i.e.,