PPC64: Changing test-spaces/SizeOfInitialHeap to accomodate 64K page size

PPC64: Changing test-spaces/SizeOfInitialHeap to accomodate 64K page size

    Since the page size of PPC 64 bit machines is 64K, memory smaller than 64K
    cannot be freed causing the committed memory of code space to be
    exactly 2M. Changing the test case to accomodate this.

R=mlippautz@chromium.org, ulan@chromium.org, vogelheim@chromium.org
BUG=

Committed: https://crrev.com/f5d373b0125eb7e88ae0e7360f0d78ce5fb5a762
Cr-Commit-Position: refs/heads/master@{#41292}

[yangtian.zi, 2016-11-23 19:40:37]

ptal

[vogelheim, 2016-11-24 08:42:19]

On 2016/11/23 19:40:37, yangtian.zi wrote:
> ptal

I'm not a good reviewer for this, as I don't understand the heap code very well.

[vogelheim, 2016-11-24 08:42:28]

Description was changed from

==========
PPC64: Changing test-spaces/SizeOfInitialHeap to accomodate 64K page size

    Since the page size of PPC 64 bit machines is 64K, memory smaller than 64K
    cannot be freed causing the committed memory of code space to be
    exactly 2M. Changing the test case to accomodate this.

R=mlippautz@chromium.org, ulan@chromium.org, vogelheim@chromium.org
BUG=
==========

to

==========
PPC64: Changing test-spaces/SizeOfInitialHeap to accomodate 64K page size

    Since the page size of PPC 64 bit machines is 64K, memory smaller than 64K
    cannot be freed causing the committed memory of code space to be
    exactly 2M. Changing the test case to accomodate this.

R=mlippautz@chromium.org, ulan@chromium.org, vogelheim@chromium.org
BUG=
==========

[vogelheim, 2016-11-24 08:42:28]

Description was changed from

==========
PPC64: Changing test-spaces/SizeOfInitialHeap to accomodate 64K page size

    Since the page size of PPC 64 bit machines is 64K, memory smaller than 64K
    cannot be freed causing the committed memory of code space to be
    exactly 2M. Changing the test case to accomodate this.

R=mlippautz@chromium.org, ulan@chromium.org, vogelheim@chromium.org
BUG=
==========

to

==========
PPC64: Changing test-spaces/SizeOfInitialHeap to accomodate 64K page size

    Since the page size of PPC 64 bit machines is 64K, memory smaller than 64K
    cannot be freed causing the committed memory of code space to be
    exactly 2M. Changing the test case to accomodate this.

R=mlippautz@chromium.org, ulan@chromium.org, vogelheim@chromium.org
BUG=
==========

[vogelheim, 2016-11-24 08:42:28]

vogelheim@chromium.org changed reviewers:
- vogelheim@chromium.org

[vogelheim, 2016-11-24 08:42:28]

vogelheim@chromium.org changed reviewers:
- vogelheim@chromium.org

[Michael Lippautz, 2016-11-25 15:23:51]

https://codereview.chromium.org/2523293002/diff/1/test/cctest/heap/test-space...
File test/cctest/heap/test-spaces.cc (right):

https://codereview.chromium.org/2523293002/diff/1/test/cctest/heap/test-space...
test/cctest/heap/test-spaces.cc:524:
CHECK_LE(heap->paged_space(i)->CommittedMemory(), kMaxInitialSizePerSpace);
I would put the #define_s around kMaxInitialSizePerSpace above and just make it
slightly larger. This constant is arbitrary and should just help us in
recognizing any regressions.

Also, there's no memory being freed here as we do these checks right after
deserialization. So I would write something along the lines of "For 64k pages we
have more fragmentation and need a larger limit."

[yangtian.zi, 2016-11-25 16:30:30]

made suggested change - PTAL

[Michael Lippautz, 2016-11-25 16:39:23]

lgtm

[yangtian.zi, 2016-11-25 18:07:58]

The CQ bit was checked by ziyang@ca.ibm.com

[commit-bot: I haz the power, 2016-11-25 18:08:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 19:37:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480097278082700,
"parent_rev": "b42d8f6a9d73f8733c7ea598b87d8c4cbdcfa338", "commit_rev":
"b98c7c4d577a33750220dfc89d1029ed2bb6fb78"}

[commit-bot: I haz the power, 2016-11-25 19:37:59]

Description was changed from

==========
PPC64: Changing test-spaces/SizeOfInitialHeap to accomodate 64K page size

    Since the page size of PPC 64 bit machines is 64K, memory smaller than 64K
    cannot be freed causing the committed memory of code space to be
    exactly 2M. Changing the test case to accomodate this.

R=mlippautz@chromium.org, ulan@chromium.org, vogelheim@chromium.org
BUG=
==========

to

==========
PPC64: Changing test-spaces/SizeOfInitialHeap to accomodate 64K page size

    Since the page size of PPC 64 bit machines is 64K, memory smaller than 64K
    cannot be freed causing the committed memory of code space to be
    exactly 2M. Changing the test case to accomodate this.

R=mlippautz@chromium.org, ulan@chromium.org, vogelheim@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2016-11-25 19:38:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-25 19:38:25]

Description was changed from

==========
PPC64: Changing test-spaces/SizeOfInitialHeap to accomodate 64K page size

    Since the page size of PPC 64 bit machines is 64K, memory smaller than 64K
    cannot be freed causing the committed memory of code space to be
    exactly 2M. Changing the test case to accomodate this.

R=mlippautz@chromium.org, ulan@chromium.org, vogelheim@chromium.org
BUG=
==========

to

==========
PPC64: Changing test-spaces/SizeOfInitialHeap to accomodate 64K page size

    Since the page size of PPC 64 bit machines is 64K, memory smaller than 64K
    cannot be freed causing the committed memory of code space to be
    exactly 2M. Changing the test case to accomodate this.

R=mlippautz@chromium.org, ulan@chromium.org, vogelheim@chromium.org
BUG=

Committed: https://crrev.com/f5d373b0125eb7e88ae0e7360f0d78ce5fb5a762
Cr-Commit-Position: refs/heads/master@{#41292}
==========

[commit-bot: I haz the power, 2016-11-25 19:38:26]

Patchset 2 (id:??) landed as
https://crrev.com/f5d373b0125eb7e88ae0e7360f0d78ce5fb5a762
Cr-Commit-Position: refs/heads/master@{#41292}