Issue 2523283002: M56: Make printing work for PDF and Flash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2523283002: M56: Make printing work for PDF and Flash. (Closed)

Created:
4 years ago by Lei Zhang

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

M56: Make printing work for PDF and Flash. BUG=666432 Review-Url: https://codereview.chromium.org/2518993002 Cr-Commit-Position: refs/heads/master@{#433657} (cherry picked from commit 4665756d5cdece234b38a2c722f2489a5c53a647) Committed: https://chromium.googlesource.com/chromium/src/+/b1780aa52d15b9a07d47d1a35763bc5f5d2233a7

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -5 lines)			Patch
M	chrome/browser/printing/print_preview_message_handler.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/printing/print_preview_message_handler.cc	View	2 chunks	+13 lines, -3 lines	0 comments	Download
M	chrome/browser/printing/print_view_manager.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/printing/print_view_manager.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Lei Zhang

4 years ago (2016-11-23 19:29:24 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b1780aa52d15b9a07d47d1a35763bc5f5d2233a7.