tools/turbolizer/node.js - Issue 2523263003: [turbolizer] Fix distinguishing simplified nodes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/turbolizer/node.js

Issue 2523263003: [turbolizer] Fix distinguishing simplified nodes (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/turbolizer/node.js

diff --git a/tools/turbolizer/node.js b/tools/turbolizer/node.js

index 3656e5d7e5a547482be17df9639adaed216defb3..b718cdc4dfee34bfe48c9e9f8227de1d9fb5040a 100644

--- a/tools/turbolizer/node.js

+++ b/tools/turbolizer/node.js

@@ -26,7 +26,7 @@ var Node = {

return this.opcode.startsWith('JS');

isSimplified: function() {

- if (this.isJavaScript) return false;

+ if (this.isJavaScript()) return false;

return this.opcode.endsWith('Phi') ||

this.opcode.startsWith('Boolean') ||

this.opcode.startsWith('Number') ||

« no previous file with comments | « no previous file | no next file » | no next file with comments »