Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2523253002: Convert use_seccomp_bpf to the BUILDFLAG system. (Closed)

Created:
4 years ago by Robert Sesek
Modified:
4 years ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, droger+watchlist_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, rickyz+watch_chromium.org, darin-cc_chromium.org, jln+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert use_seccomp_bpf to the BUILDFLAG system. BUG=589674 Committed: https://crrev.com/7b1273af06ffb033a47bd1837eb16ce13798a74e Cr-Commit-Position: refs/heads/master@{#436715}

Patch Set 1 : '' #

Patch Set 2 : NaCl #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -42 lines) Patch
M build/config/features.gni View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 3 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/android/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/seccomp_support_detector.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/nacl/loader/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/nacl/loader/sandbox_linux/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M components/nacl/loader/sandbox_linux/nacl_bpf_sandbox_linux.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M content/BUILD.gn View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/common/BUILD.gn View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M content/common/sandbox_linux/sandbox_seccomp_bpf_linux.cc View 7 chunks +11 lines, -10 lines 0 comments Download
M content/renderer/BUILD.gn View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate_android.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M sandbox/BUILD.gn View 2 chunks +8 lines, -0 lines 0 comments Download
A sandbox/features.gni View 1 1 chunk +16 lines, -0 lines 0 comments Download
M sandbox/linux/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 38 (29 generated)
Robert Sesek
4 years ago (2016-11-23 20:30:05 UTC) #23
Robert Sesek
Friendly post-holiday ping.
4 years ago (2016-11-28 23:10:39 UTC) #24
Robert Sesek
brettw: Please review
4 years ago (2016-12-06 15:44:41 UTC) #26
brettw
Yay! LGTM
4 years ago (2016-12-06 17:55:43 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523253002/80001
4 years ago (2016-12-06 18:09:39 UTC) #29
commit-bot: I haz the power
Failed to apply patch for chrome/browser/BUILD.gn: While running git apply --index -p1; error: patch failed: ...
4 years ago (2016-12-06 19:15:42 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523253002/100001
4 years ago (2016-12-06 19:47:36 UTC) #34
commit-bot: I haz the power
Committed patchset #3 (id:100001)
4 years ago (2016-12-06 20:56:19 UTC) #36
commit-bot: I haz the power
4 years ago (2016-12-06 20:59:49 UTC) #38
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7b1273af06ffb033a47bd1837eb16ce13798a74e
Cr-Commit-Position: refs/heads/master@{#436715}

Powered by Google App Engine
This is Rietveld 408576698