[css-grid] Implied minimum size only applies if overflow is visible

third_party/WebKit/Source/core/layout/LayoutGrid.cpp

Index: third_party/WebKit/Source/core/layout/LayoutGrid.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
index 361720fa2aa0271a698e9a718821f2587cf8346f..aceda264c09ee0bc15c02adb5c0f9a535bda5ba5 100644
--- a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
@@ -1242,7 +1242,10 @@ LayoutUnit LayoutGrid::minSizeForChild(LayoutBox& child,
                                       : child.styleRef().logicalHeight();
   const Length& childMinSize = isRowAxis ? child.styleRef().logicalMinWidth()
                                          : child.styleRef().logicalMinHeight();
-  if (!childSize.isAuto() || childMinSize.isAuto())
+  bool overflowIsVisible =
+      isRowAxis ? child.styleRef().overflowInlineDirection() == OverflowVisible
+                : child.styleRef().overflowBlockDirection() == OverflowVisible;
+  if (!childSize.isAuto() || (childMinSize.isAuto() && overflowIsVisible))

[jfernandez, 2016/11/23 15:59:30]

why overflow visibility only applied if childMinSize is auto ? 

[Manuel Rego, 2016/11/23 16:24:36]

It's what we're precisely fixing here, check the text on the spec
(https://drafts.csswg.org/css-grid/#min-size-auto):
"applies an automatic minimum size in the specified axis
 to grid items whose 'overflow' is 'visible'."

     return minContentForChild(child, direction, sizingData);
 
   bool overrideSizeHasChanged =