Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 252323004: disable VirtualKeyboardTest.Attributes until Object.observe is re-enabled (Closed)

Created:
6 years, 7 months ago by rafaelw
Modified:
6 years, 7 months ago
Reviewers:
robliao, ajwong, awong
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

disable VirtualKeyboardTest.Attributes until Object.observe is re-enabled NOTREECHECKS=true NOTRY=true TBR=ajwong BUG=367817 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266988

Patch Set 1 #

Patch Set 2 : sync #

Patch Set 3 : sync #

Patch Set 4 : wee #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/chromeos/extensions/virtual_keyboard_browsertest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
awong
LGTM
6 years, 7 months ago (2014-04-29 22:41:42 UTC) #1
rafaelw
The CQ bit was checked by rafaelw@chromium.org
6 years, 7 months ago (2014-04-29 22:53:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rafaelw@chromium.org/252323004/60001
6 years, 7 months ago (2014-04-29 22:56:24 UTC) #3
robliao
The CQ bit was unchecked by robliao@chromium.org
6 years, 7 months ago (2014-04-29 22:56:26 UTC) #4
robliao
The CQ bit was checked by robliao@chromium.org
6 years, 7 months ago (2014-04-29 22:56:29 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 22:57:58 UTC) #6
commit-bot: I haz the power
List of reviewers changed. robliao@chromium.org did a drive-by without LGTM'ing!
6 years, 7 months ago (2014-04-29 22:57:58 UTC) #7
robliao
On 2014/04/29 22:57:58, I haz the power (commit-bot) wrote: > List of reviewers changed. mailto:robliao@chromium.org ...
6 years, 7 months ago (2014-04-29 22:58:18 UTC) #8
robliao
The CQ bit was checked by robliao@chromium.org
6 years, 7 months ago (2014-04-29 22:58:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rafaelw@chromium.org/252323004/60001
6 years, 7 months ago (2014-04-29 23:00:57 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 23:02:52 UTC) #11
Message was sent while issue was closed. 
Change committed as 266988

Powered by Google App Engine
This is Rietveld 408576698