Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2523223003: Merged: Squashed multiple commits. (Closed)

Created:
4 years ago by Benedikt Meurer
Modified:
4 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.6
Project:
v8
Visibility:
Public.

Description

Merged: Squashed multiple commits. Merged: [turbofan] Properly optimize instanceof (even in the presence of @@hasInstance). Revision: 241c024c10a8c1b5d7309299ef61f887363b00a0 Merged: [turbofan] Fix broken effect chain for instanceof. Revision: 84c9360b82127571548c9d93132819a4174a0ea1 BUG=chromium:667689, v8:5640 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=jarin@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/c6856126b6f02d55677a84afa22c7b51afae66a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+345 lines, -74 lines) Patch
M src/bootstrapper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins/builtins-object.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/code-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 2 chunks +31 lines, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 2 chunks +89 lines, -0 lines 0 comments Download
M src/compiler/js-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 4 chunks +32 lines, -35 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/operator-properties.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/compiler/instanceof.js View 1 chunk +133 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-667689.js View 1 chunk +16 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
4 years ago (2016-11-23 13:04:37 UTC) #1
Benedikt Meurer
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
4 years ago (2016-11-23 13:04:38 UTC) #2
Benedikt Meurer
4 years ago (2016-11-23 13:06:46 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c6856126b6f02d55677a84afa22c7b51afae66a2.

Powered by Google App Engine
This is Rietveld 408576698