Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2523193002:
[Autofill] Add a content_renderer manifest overlay for android_webview. (Closed)
|
Created:
4 years ago by leonhsl(Using Gerrit) Modified:
4 years ago CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Autofill] Add a content_renderer manifest overlay for android_webview.
This CL creates a content_renderer service manifest overly for android_webview
to enable autofill mojo interfaces to be accessed well from content_browser
service.
BUG=662040
Committed: https://crrev.com/9540b28d2181dc7d9cd86c3b7999bf5f4a23dc1f
Cr-Commit-Position: refs/heads/master@{#434722}
Patch Set 1 #Patch Set 2 : Create content_renderer manifest overlay for android webview #
Messages
Total messages: 38 (24 generated)
The CQ bit was checked by leon.han@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
leon.han@intel.com changed reviewers: + rockot@chromium.org, tsepez@chromium.org
Hi, Ken, Tom, Autofill autocomplete feature works well in Chrome but NG in Android Webview, then I found such error log: ' 11-23 21:55:37.069 17038 17066 E chromium: [ERROR:interface_registry.cc(218)] InterfaceProviderSpec "navigation:frame" prevented service: content_browser from binding interface: autofill::mojom::AutofillAgent exposed by: content_renderer ' To solve, this CL puts those autofill interfaces into content renderer manifest directly, instead of putting them into chrome renderer manifest overlay, because I think they should be available for all content embedders. Or should we just create another renderer manifest overlay for android_webview? WDYT? Thanks. #Note: Locally confirmed that autofill autocomplete feature for android webview becomes OK with this CL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
tsepez@chromium.org changed reviewers: + ben@chromium.org
I'm not sure if this would violate layering.
On 2016/11/23 at 16:29:44, tsepez wrote: > I'm not sure if this would violate layering. Yes, this violates layering. The correct thing to do is add an overlay for AW renderer. See the browser overlay here: https://cs.chromium.org/chromium/src/android_webview/browser/aw_browser_manif...
On 2016/11/23 16:50:30, Ken Rockot wrote: > On 2016/11/23 at 16:29:44, tsepez wrote: > > I'm not sure if this would violate layering. > > Yes, this violates layering. > > The correct thing to do is add an overlay for AW renderer. See the browser > overlay here: > https://cs.chromium.org/chromium/src/android_webview/browser/aw_browser_manif... OK seems current solution is a workaround:) I'll create an AW renderer manifest overlay instead. Thanks Ken and Tom!
The CQ bit was checked by leon.han@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Uploaded ps#2, PTAnL, Thanks. #Locally confirmed OK.
Description was changed from ========== [Autofill] Enable mojo interfaces access for android_webview. Android webview also needs autofill mojo interfaces running well. BUG=662040 ========== to ========== [Autofill] Enable mojo interfaces access for android_webview. This CL creates a content_renderer service manifest overly for android_webview to enable autofill mojo interfaces to be accessed well from content_browser service. BUG=662040 ==========
leon.han@intel.com changed reviewers: + sgurun@chromium.org
+sgurun@ as android_webview OWNER. Thanks.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by leon.han@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by leon.han@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
Description was changed from ========== [Autofill] Enable mojo interfaces access for android_webview. This CL creates a content_renderer service manifest overly for android_webview to enable autofill mojo interfaces to be accessed well from content_browser service. BUG=662040 ========== to ========== [Autofill] Add a content_renderer manifest overlay for android_webview. This CL creates a content_renderer service manifest overly for android_webview to enable autofill mojo interfaces to be accessed well from content_browser service. BUG=662040 ==========
Friendly ping~ Thanks.
RS LGTM
On 2016/11/28 17:25:43, Tom Sepez wrote: > RS LGTM lgtm
The CQ bit was checked by sgurun@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
rs lgtm fwiw
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480358052152480,
"parent_rev": "598894411098bd64e26456eae44fa444b6073bb1", "commit_rev":
"6b1bda224de5732daa402d6de222bad096c6e530"}
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Autofill] Add a content_renderer manifest overlay for android_webview. This CL creates a content_renderer service manifest overly for android_webview to enable autofill mojo interfaces to be accessed well from content_browser service. BUG=662040 ========== to ========== [Autofill] Add a content_renderer manifest overlay for android_webview. This CL creates a content_renderer service manifest overly for android_webview to enable autofill mojo interfaces to be accessed well from content_browser service. BUG=662040 Committed: https://crrev.com/9540b28d2181dc7d9cd86c3b7999bf5f4a23dc1f Cr-Commit-Position: refs/heads/master@{#434722} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/9540b28d2181dc7d9cd86c3b7999bf5f4a23dc1f Cr-Commit-Position: refs/heads/master@{#434722} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
