Issue 2523183002: VM: [Kernel] Go back to previous behavior in loader.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2523183002: VM: [Kernel] Go back to previous behavior in loader.cc (Closed)

Created:
4 years ago by kustermann

Modified:
4 years ago

Reviewers:
Vyacheslav Egorov (Google), Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

VM: [Kernel] Go back to previous behavior in loader.cc Committed: https://github.com/dart-lang/sdk/commit/2c9cbb1d2cc1f489245cb3cddc61014cbdfe6feb

Patch Set 1 #

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	runtime/bin/loader.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kustermann

My comment on the previous CL (https://codereview.chromium.org/2525623002/diff/1/runtime/bin/loader.cc#oldcode374) was actually wrong. We still hit it in ...

4 years ago (2016-11-23 09:44:31 UTC) #2

kustermann

Committed patchset #1 (id:1) manually as 2c9cbb1d2cc1f489245cb3cddc61014cbdfe6feb (presubmit successful).

4 years ago (2016-11-23 09:56:07 UTC) #5

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages