Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2523173002: [ic] Don't enable property cell mode for a LoadGlobalIC if the holder is a different global object … (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Don't enable property cell mode for a LoadGlobalIC if the holder is a different global object than the receiver. Test contributed by crlf0710 <crlf0710@gmail.com>;. BUG=v8:5552 Committed: https://crrev.com/b2f2f6ecf1aa29137cba65c6ce810b563776e498 Cr-Commit-Position: refs/heads/master@{#41213}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -6 lines) Patch
M src/ic/ic.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M test/cctest/test-global-object.cc View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Igor Sheludko
PTAL
4 years ago (2016-11-23 09:41:06 UTC) #7
Jakob Kummerow
lgtm
4 years ago (2016-11-23 12:12:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523173002/1
4 years ago (2016-11-23 12:13:53 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 12:16:31 UTC) #15
commit-bot: I haz the power
4 years ago (2016-11-23 12:17:08 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2f2f6ecf1aa29137cba65c6ce810b563776e498
Cr-Commit-Position: refs/heads/master@{#41213}

Powered by Google App Engine
This is Rietveld 408576698