Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2523133002: Fuchsia sockets: (Closed)

Created:
4 years, 1 month ago by rmacnak
Modified:
4 years, 1 month ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fuchsia sockets: - Remove CheckConnect. - Enable NODELAY. - Add testSimpleReadWriteClose to hello_fuchsia_test. Add stub implementation of OS::MaxRSS so Observatory can load without crashing the target VM. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/171da0489fd6a1b4b99c4d5c1dd2af3faf13294f

Patch Set 1 #

Patch Set 2 : comment #

Patch Set 3 : Enable NODELAY #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -40 lines) Patch
M runtime/bin/socket_fuchsia.cc View 1 2 2 chunks +0 lines, -33 lines 0 comments Download
M runtime/tests/vm/dart/hello_fuchsia_test.dart View 1 3 chunks +149 lines, -6 lines 0 comments Download
M runtime/vm/os_fuchsia.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
rmacnak
4 years, 1 month ago (2016-11-22 23:53:04 UTC) #2
siva
lgtm
4 years, 1 month ago (2016-11-23 00:51:14 UTC) #5
rmacnak
4 years, 1 month ago (2016-11-23 00:52:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
171da0489fd6a1b4b99c4d5c1dd2af3faf13294f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698