Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2523093003: Use CFX_MaybeOwned<> in CPDF_Image (Closed)

Created:
4 years ago by Tom Sepez
Modified:
4 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -28 lines) Patch
M core/fpdfapi/page/cpdf_image.h View 3 chunks +5 lines, -6 lines 0 comments Download
M core/fpdfapi/page/cpdf_image.cpp View 7 chunks +20 lines, -22 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Tom Sepez
Lei, follow-on.
4 years ago (2016-11-23 20:24:38 UTC) #2
Lei Zhang
lgtm
4 years ago (2016-11-23 20:29:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523093003/40001
4 years ago (2016-11-23 22:24:38 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-23 22:35:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/9fd0c630ea2225fc544949d88d1bf63acc43...

Powered by Google App Engine
This is Rietveld 408576698