Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: chrome/browser/download/download_request_limiter_unittest.cc

Issue 2523093002: TestBrowserThreads must outlive TestProfiles and TestProfileManagers (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/prerender/prerender_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_request_limiter_unittest.cc
diff --git a/chrome/browser/download/download_request_limiter_unittest.cc b/chrome/browser/download/download_request_limiter_unittest.cc
index 59d119049066f9d3d7bb62711ef99f816ead9362..14d15026609ad3aeacccf0acd276e31848ee1a05 100644
--- a/chrome/browser/download/download_request_limiter_unittest.cc
+++ b/chrome/browser/download/download_request_limiter_unittest.cc
@@ -161,6 +161,11 @@ class DownloadRequestLimiterTest : public ChromeRenderViewHostTestHarness {
content_settings_->ShutdownOnUIThread();
content_settings_ = nullptr;
testing_delegate_.TearDown();
+
+ // |profile_| must be teared down before
+ // |RenderViewHostTestHarness::thread_bundle_|.
+ profile_.reset();
+
ChromeRenderViewHostTestHarness::TearDown();
}
« no previous file with comments | « no previous file | chrome/browser/prerender/prerender_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698