Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: chrome/browser/prerender/prerender_unittest.cc

Issue 2523093002: TestBrowserThreads must outlive TestProfiles and TestProfileManagers (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <stdint.h> 6 #include <stdint.h>
7 7
8 #include <map> 8 #include <map>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 387 matching lines...) Expand 10 before | Expand all | Expand 10 after
398 398
399 void EnablePrerender() { 399 void EnablePrerender() {
400 profile_.GetPrefs()->SetInteger( 400 profile_.GetPrefs()->SetInteger(
401 prefs::kNetworkPredictionOptions, 401 prefs::kNetworkPredictionOptions,
402 chrome_browser_net::NETWORK_PREDICTION_ALWAYS); 402 chrome_browser_net::NETWORK_PREDICTION_ALWAYS);
403 } 403 }
404 404
405 private: 405 private:
406 // Needed to pass PrerenderManager's DCHECKs. 406 // Needed to pass PrerenderManager's DCHECKs.
407 base::MessageLoop message_loop_; 407 base::MessageLoop message_loop_;
408 content::TestBrowserThread ui_thread_;
409
408 TestingProfile profile_; 410 TestingProfile profile_;
409 content::TestBrowserThread ui_thread_;
410 std::unique_ptr<UnitTestPrerenderManager> prerender_manager_; 411 std::unique_ptr<UnitTestPrerenderManager> prerender_manager_;
411 std::unique_ptr<PrerenderLinkManager> prerender_link_manager_; 412 std::unique_ptr<PrerenderLinkManager> prerender_link_manager_;
412 int last_prerender_id_; 413 int last_prerender_id_;
413 base::FieldTrialList field_trial_list_; 414 base::FieldTrialList field_trial_list_;
414 }; 415 };
415 416
416 TEST_F(PrerenderTest, PrerenderRespectsDisableFlag) { 417 TEST_F(PrerenderTest, PrerenderRespectsDisableFlag) {
417 RestorePrerenderMode restore_prerender_mode; 418 RestorePrerenderMode restore_prerender_mode;
418 ASSERT_TRUE(PrerenderManager::IsPrerenderingPossible()); 419 ASSERT_TRUE(PrerenderManager::IsPrerenderingPossible());
419 base::CommandLine* command_line = base::CommandLine::ForCurrentProcess(); 420 base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
(...skipping 1364 matching lines...) Expand 10 before | Expand all | Expand 10 after
1784 prerender_contents->SetPrerenderMode(PREFETCH_ONLY); 1785 prerender_contents->SetPrerenderMode(PREFETCH_ONLY);
1785 EXPECT_TRUE(prerender_contents->IsValidHttpMethod("GET")); 1786 EXPECT_TRUE(prerender_contents->IsValidHttpMethod("GET"));
1786 EXPECT_TRUE(prerender_contents->IsValidHttpMethod("HEAD")); 1787 EXPECT_TRUE(prerender_contents->IsValidHttpMethod("HEAD"));
1787 EXPECT_FALSE(prerender_contents->IsValidHttpMethod("OPTIONS")); 1788 EXPECT_FALSE(prerender_contents->IsValidHttpMethod("OPTIONS"));
1788 EXPECT_FALSE(prerender_contents->IsValidHttpMethod("POST")); 1789 EXPECT_FALSE(prerender_contents->IsValidHttpMethod("POST"));
1789 EXPECT_FALSE(prerender_contents->IsValidHttpMethod("TRACE")); 1790 EXPECT_FALSE(prerender_contents->IsValidHttpMethod("TRACE"));
1790 EXPECT_FALSE(prerender_contents->IsValidHttpMethod("WHATEVER")); 1791 EXPECT_FALSE(prerender_contents->IsValidHttpMethod("WHATEVER"));
1791 } 1792 }
1792 1793
1793 } // namespace prerender 1794 } // namespace prerender
OLDNEW
« no previous file with comments | « chrome/browser/download/download_request_limiter_unittest.cc ('k') | chrome/browser/profiles/profile_info_cache_unittest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698