Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Side by Side Diff: cc/debug/devtools_instrumentation.h

Issue 2523063002: Size reduction from moving const char arrays out of header (Closed)
Patch Set: Added new .cc file to patch Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/BUILD.gn ('k') | cc/debug/devtools_instrumentation.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_DEBUG_DEVTOOLS_INSTRUMENTATION_H_ 5 #ifndef CC_DEBUG_DEVTOOLS_INSTRUMENTATION_H_
6 #define CC_DEBUG_DEVTOOLS_INSTRUMENTATION_H_ 6 #define CC_DEBUG_DEVTOOLS_INSTRUMENTATION_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
11 11
12 #include "base/macros.h" 12 #include "base/macros.h"
13 #include "base/metrics/histogram_macros.h" 13 #include "base/metrics/histogram_macros.h"
14 #include "base/trace_event/trace_event.h" 14 #include "base/trace_event/trace_event.h"
15 #include "base/trace_event/trace_event_argument.h" 15 #include "base/trace_event/trace_event_argument.h"
16 16
17 namespace cc { 17 namespace cc {
18 namespace devtools_instrumentation { 18 namespace devtools_instrumentation {
19 19
20 namespace internal { 20 namespace internal {
21 const char kCategory[] = TRACE_DISABLED_BY_DEFAULT("devtools.timeline"); 21 extern const char kCategory[];
22 const char kCategoryFrame[] = 22 extern const char kCategoryFrame[];
23 TRACE_DISABLED_BY_DEFAULT("devtools.timeline.frame"); 23 extern const char kData[];
24 const char kData[] = "data"; 24 extern const char kFrameId[];
25 const char kFrameId[] = "frameId"; 25 extern const char kLayerId[];
26 const char kLayerId[] = "layerId"; 26 extern const char kLayerTreeId[];
27 const char kLayerTreeId[] = "layerTreeId"; 27 extern const char kPixelRefId[];
28 const char kPixelRefId[] = "pixelRefId";
29 28
30 const char kImageDecodeTask[] = "ImageDecodeTask"; 29 extern const char kImageDecodeTask[];
31 const char kBeginFrame[] = "BeginFrame"; 30 extern const char kBeginFrame[];
32 const char kNeedsBeginFrameChanged[] = "NeedsBeginFrameChanged"; 31 extern const char kNeedsBeginFrameChanged[];
33 const char kActivateLayerTree[] = "ActivateLayerTree"; 32 extern const char kActivateLayerTree[];
34 const char kRequestMainThreadFrame[] = "RequestMainThreadFrame"; 33 extern const char kRequestMainThreadFrame[];
35 const char kBeginMainThreadFrame[] = "BeginMainThreadFrame"; 34 extern const char kBeginMainThreadFrame[];
36 const char kDrawFrame[] = "DrawFrame"; 35 extern const char kDrawFrame[];
37 const char kCompositeLayers[] = "CompositeLayers"; 36 extern const char kCompositeLayers[];
38 } // namespace internal 37 } // namespace internal
39 38
40 const char kPaintSetup[] = "PaintSetup"; 39 extern const char kPaintSetup[];
41 const char kUpdateLayer[] = "UpdateLayer"; 40 extern const char kUpdateLayer[];
42 41
43 class ScopedLayerTask { 42 class ScopedLayerTask {
44 public: 43 public:
45 ScopedLayerTask(const char* event_name, int layer_id) 44 ScopedLayerTask(const char* event_name, int layer_id)
46 : event_name_(event_name) { 45 : event_name_(event_name) {
47 TRACE_EVENT_BEGIN1(internal::kCategory, event_name_, 46 TRACE_EVENT_BEGIN1(internal::kCategory, event_name_,
48 internal::kLayerId, layer_id); 47 internal::kLayerId, layer_id);
49 } 48 }
50 ~ScopedLayerTask() { 49 ~ScopedLayerTask() {
51 TRACE_EVENT_END0(internal::kCategory, event_name_); 50 TRACE_EVENT_END0(internal::kCategory, event_name_);
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 TRACE_EVENT_INSTANT2( 193 TRACE_EVENT_INSTANT2(
195 internal::kCategoryFrame, internal::kNeedsBeginFrameChanged, 194 internal::kCategoryFrame, internal::kNeedsBeginFrameChanged,
196 TRACE_EVENT_SCOPE_THREAD, internal::kLayerTreeId, layer_tree_host_id, 195 TRACE_EVENT_SCOPE_THREAD, internal::kLayerTreeId, layer_tree_host_id,
197 internal::kData, NeedsBeginFrameData(new_value)); 196 internal::kData, NeedsBeginFrameData(new_value));
198 } 197 }
199 198
200 } // namespace devtools_instrumentation 199 } // namespace devtools_instrumentation
201 } // namespace cc 200 } // namespace cc
202 201
203 #endif // CC_DEBUG_DEVTOOLS_INSTRUMENTATION_H_ 202 #endif // CC_DEBUG_DEVTOOLS_INSTRUMENTATION_H_
OLDNEW
« no previous file with comments | « cc/BUILD.gn ('k') | cc/debug/devtools_instrumentation.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698