Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Side by Side Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller.h

Issue 2523053004: Enhance chrome.app.window API for shelf integration with restore support (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 // Closes the specified item. 132 // Closes the specified item.
133 virtual void Close(ash::ShelfID id) = 0; 133 virtual void Close(ash::ShelfID id) = 0;
134 134
135 // Returns true if the specified item is open. 135 // Returns true if the specified item is open.
136 virtual bool IsOpen(ash::ShelfID id) = 0; 136 virtual bool IsOpen(ash::ShelfID id) = 0;
137 137
138 // Returns true if the specified item is for a platform app. 138 // Returns true if the specified item is for a platform app.
139 virtual bool IsPlatformApp(ash::ShelfID id) = 0; 139 virtual bool IsPlatformApp(ash::ShelfID id) = 0;
140 140
141 // Opens a new instance of the application identified by |app_id|. 141 // Opens a new instance of the application identified by |app_id|.
142 // Used by the app-list, and by pinned-app shelf items. 142 // Used by the app-list, and by pinned-app shelf items.|launch_id| is an id
143 // that can be passed to an app when launched in order to support multiple
144 // shelf items per app.
143 void LaunchApp(const std::string& app_id, 145 void LaunchApp(const std::string& app_id,
146 const std::string& launch_id,
144 ash::LaunchSource source, 147 ash::LaunchSource source,
145 int event_flags); 148 int event_flags);
stevenjb 2016/12/05 16:47:31 Same here, we seem to have a lot of existing calls
Andra Paraschiv 2016/12/06 13:19:16 Done.
146 149
147 // If |app_id| is running, reactivates the app's most recently active window, 150 // If |app_id| is running, reactivates the app's most recently active window,
148 // otherwise launches and activates the app. 151 // otherwise launches and activates the app.
149 // Used by the app-list, and by pinned-app shelf items. 152 // Used by the app-list, and by pinned-app shelf items.
150 virtual void ActivateApp(const std::string& app_id, 153 virtual void ActivateApp(const std::string& app_id,
151 ash::LaunchSource source, 154 ash::LaunchSource source,
152 int event_flags) = 0; 155 int event_flags) = 0;
153 156
154 // Returns the launch type of app for the specified id. 157 // Returns the launch type of app for the specified id.
155 virtual extensions::LaunchType GetLaunchType(ash::ShelfID id) = 0; 158 virtual extensions::LaunchType GetLaunchType(ash::ShelfID id) = 0;
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
315 // An observer that manages the shelf title and icon for settings windows. 318 // An observer that manages the shelf title and icon for settings windows.
316 SettingsWindowObserver settings_window_observer_; 319 SettingsWindowObserver settings_window_observer_;
317 320
318 // Used to load the images for app items. 321 // Used to load the images for app items.
319 std::vector<std::unique_ptr<AppIconLoader>> app_icon_loaders_; 322 std::vector<std::unique_ptr<AppIconLoader>> app_icon_loaders_;
320 323
321 DISALLOW_COPY_AND_ASSIGN(ChromeLauncherController); 324 DISALLOW_COPY_AND_ASSIGN(ChromeLauncherController);
322 }; 325 };
323 326
324 #endif // CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_H_ 327 #endif // CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698