Enhance chrome.app.window API for shelf integration with restore support

apps/launcher.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef APPS_LAUNCHER_H_
 #define APPS_LAUNCHER_H_
 
 #include <memory>
 #include <string>
 #include <vector>
@@ skipping 18 matching lines @@
 }
 }
 
 namespace apps {
 
 // Launches the platform app |app|. Creates appropriate launch data for the
 // |command_line| fields present. |app| and |profile| must not be NULL. An empty
 // |command_line| means there is no launch data. If non-empty,
 // |current_directory| is used to expand any relative paths on the command line.
 // |source| is one of the enumerated values which trace how the app is launched.
+// |launch_id| is an id that can be passed to an app when launched in order to

[Mr4D (OOO till 08-26), 2016/12/03 01:55:27]

Could you please order the parameters in the proper order?

[Andra Paraschiv, 2016/12/06 13:19:16]

Done.

+// support multiple shelf items per app.
 void LaunchPlatformAppWithCommandLine(
     Profile* profile,
     const extensions::Extension* app,
+    const std::string& launch_id,
     const base::CommandLine& command_line,
     const base::FilePath& current_directory,
     extensions::AppLaunchSource source,
     extensions::api::app_runtime::PlayStoreStatus play_store_status =
         extensions::api::app_runtime::PlayStoreStatus::
             PLAY_STORE_STATUS_UNKNOWN);

[stevenjb, 2016/12/05 16:47:31]

Given that we already have a bunch of these, I would rather add one more (e.g.
LaunchPlatformAppWithCommandLineAndLaunchId) than add "" to a bunch of existing
calls. Otherwise, we also need to include /* launch_id */ after "" in all of
those calls.

[Andra Paraschiv, 2016/12/06 13:19:16]

Thank you, I added a new one.

 
 // Launches the platform app |app| by issuing an onLaunched event with the
 // contents of |file_path| available through the launch data.
 void LaunchPlatformAppWithPath(Profile* profile,
                                const extensions::Extension* app,
                                const base::FilePath& file_path);
 
 // Launches the platform app |app| with the specific |action_data|. |file_path|
 // is an optional argument and if present contains the file that the app should
 // open w.r.t. the given action.
@@ skipping 26 matching lines @@
                               const extensions::Extension* app,
                               const std::string& handler_id,
                               const GURL& url,
                               const GURL& referrer_url);
 
 void RestartPlatformApp(Profile* profile, const extensions::Extension* app);
 
 }  // namespace apps
 
 #endif  // APPS_LAUNCHER_H_