Mac: Fix errors in adding the "Paste & Go" menu item.

Mac: Fix errors in adding the "Paste & Go" menu item.

AutocompleteTextFieldObserver::GetPasteActionStringId() says "Must not
be called unless CanPasteAndGo() returns true." But it doesn't look like
-[AutocompleteTextFieldEditor menuForEvent:] ever actually checked
`CanPasteAndGo()` before adding the menu item.

Currently, if the clipboard is empty (or Chrome failed to access it),
GetPasteActionStringId() will DCHECK when omnibox/clipboard_utils'
GetClipboardText() returns an empty string.

To fix, check CanPasteAndGo() and disable the menu item if it returned
false.

BUG=667512
Committed: https://crrev.com/6da03d5709d85234907de200ad5bda09a7442782
Cr-Commit-Position: refs/heads/master@{#434284}

[tapted, 2016-11-23 00:23:20]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 00:24:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2016-11-23 00:31:32]

Description was changed from

==========
cl format


fix it

BUG=667512
==========

to

==========
Mac: Fix errors in adding the "Paste & Go" menu item.

AutocompleteTextFieldObserver::GetPasteActionStringId() says "Must not
be called unless CanPasteAndGo() returns true." But it doesn't look like
-[AutocompleteTextFieldEditor menuForEvent:] ever actually checked
`CanPasteAndGo` before adding the menu item. If the clipboard is empty
(or Chrome failed to access it) then GetPasteActionStringId() will
DCHECK when omnibox/clipboard_utils' GetClipboardText() returns an empty
string.

To fix, check CanPasteAndGo() and disable the menu item if it returned
false.

BUG=667512
==========

[commit-bot: I haz the power, 2016-11-23 01:13:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 01:13:53]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tapted, 2016-11-23 02:37:38]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 02:38:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2016-11-23 03:11:06]

Description was changed from

==========
Mac: Fix errors in adding the "Paste & Go" menu item.

AutocompleteTextFieldObserver::GetPasteActionStringId() says "Must not
be called unless CanPasteAndGo() returns true." But it doesn't look like
-[AutocompleteTextFieldEditor menuForEvent:] ever actually checked
`CanPasteAndGo` before adding the menu item. If the clipboard is empty
(or Chrome failed to access it) then GetPasteActionStringId() will
DCHECK when omnibox/clipboard_utils' GetClipboardText() returns an empty
string.

To fix, check CanPasteAndGo() and disable the menu item if it returned
false.

BUG=667512
==========

to

==========
Mac: Fix errors in adding the "Paste & Go" menu item.

AutocompleteTextFieldObserver::GetPasteActionStringId() says "Must not
be called unless CanPasteAndGo() returns true." But it doesn't look like
-[AutocompleteTextFieldEditor menuForEvent:] ever actually checked
`CanPasteAndGo()` before adding the menu item.

Currently, if the clipboard is empty (or Chrome failed to access it),
GetPasteActionStringId() will DCHECK when omnibox/clipboard_utils'
GetClipboardText() returns an empty string.

To fix, check CanPasteAndGo() and disable the menu item if it returned
false.

BUG=667512
==========

[commit-bot: I haz the power, 2016-11-23 03:18:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 03:18:49]

Dry run: This issue passed the CQ dry run.

[tapted, 2016-11-23 03:23:21]

tapted@chromium.org changed reviewers:
+ erikchen@chromium.org

[tapted, 2016-11-23 03:23:22]

Hi Erik - please take a look

[erikchen, 2016-11-23 18:34:29]

thanks! lgtm

[tapted, 2016-11-23 22:36:47]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2016-11-23 22:37:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 23:49:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479940607197980,
"parent_rev": "a0c7fcc394f08388c7b49aef7c1861ddcab26f53", "commit_rev":
"f91ae7b3dc1dea70776fb11724e2ee114c8160ab"}

[commit-bot: I haz the power, 2016-11-23 23:49:43]

Description was changed from

==========
Mac: Fix errors in adding the "Paste & Go" menu item.

AutocompleteTextFieldObserver::GetPasteActionStringId() says "Must not
be called unless CanPasteAndGo() returns true." But it doesn't look like
-[AutocompleteTextFieldEditor menuForEvent:] ever actually checked
`CanPasteAndGo()` before adding the menu item.

Currently, if the clipboard is empty (or Chrome failed to access it),
GetPasteActionStringId() will DCHECK when omnibox/clipboard_utils'
GetClipboardText() returns an empty string.

To fix, check CanPasteAndGo() and disable the menu item if it returned
false.

BUG=667512
==========

to

==========
Mac: Fix errors in adding the "Paste & Go" menu item.

AutocompleteTextFieldObserver::GetPasteActionStringId() says "Must not
be called unless CanPasteAndGo() returns true." But it doesn't look like
-[AutocompleteTextFieldEditor menuForEvent:] ever actually checked
`CanPasteAndGo()` before adding the menu item.

Currently, if the clipboard is empty (or Chrome failed to access it),
GetPasteActionStringId() will DCHECK when omnibox/clipboard_utils'
GetClipboardText() returns an empty string.

To fix, check CanPasteAndGo() and disable the menu item if it returned
false.

BUG=667512
==========

[commit-bot: I haz the power, 2016-11-23 23:49:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-23 23:52:53]

Description was changed from

==========
Mac: Fix errors in adding the "Paste & Go" menu item.

AutocompleteTextFieldObserver::GetPasteActionStringId() says "Must not
be called unless CanPasteAndGo() returns true." But it doesn't look like
-[AutocompleteTextFieldEditor menuForEvent:] ever actually checked
`CanPasteAndGo()` before adding the menu item.

Currently, if the clipboard is empty (or Chrome failed to access it),
GetPasteActionStringId() will DCHECK when omnibox/clipboard_utils'
GetClipboardText() returns an empty string.

To fix, check CanPasteAndGo() and disable the menu item if it returned
false.

BUG=667512
==========

to

==========
Mac: Fix errors in adding the "Paste & Go" menu item.

AutocompleteTextFieldObserver::GetPasteActionStringId() says "Must not
be called unless CanPasteAndGo() returns true." But it doesn't look like
-[AutocompleteTextFieldEditor menuForEvent:] ever actually checked
`CanPasteAndGo()` before adding the menu item.

Currently, if the clipboard is empty (or Chrome failed to access it),
GetPasteActionStringId() will DCHECK when omnibox/clipboard_utils'
GetClipboardText() returns an empty string.

To fix, check CanPasteAndGo() and disable the menu item if it returned
false.

BUG=667512

Committed: https://crrev.com/6da03d5709d85234907de200ad5bda09a7442782
Cr-Commit-Position: refs/heads/master@{#434284}
==========

[commit-bot: I haz the power, 2016-11-23 23:52:54]

Patchset 2 (id:??) landed as
https://crrev.com/6da03d5709d85234907de200ad5bda09a7442782
Cr-Commit-Position: refs/heads/master@{#434284}