Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 2522983004: Remove obsolete declaration of DumpBacktrace() (Closed)

Created:
4 years ago by Clemens Hammacher
Modified:
4 years ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove obsolete declaration of DumpBacktrace() The implementation was removed in http://crrev.com/2248393002. R=rmcilroy@chromium.org Committed: https://crrev.com/a127fffc1b5f1d3b545607cad4089ef2b176a420 Cr-Commit-Position: refs/heads/master@{#41219}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M src/base/logging.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Clemens Hammacher
4 years ago (2016-11-23 11:35:41 UTC) #6
rmcilroy
lgtm
4 years ago (2016-11-23 12:48:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522983004/1
4 years ago (2016-11-23 12:51:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 12:53:35 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-23 12:53:54 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a127fffc1b5f1d3b545607cad4089ef2b176a420
Cr-Commit-Position: refs/heads/master@{#41219}

Powered by Google App Engine
This is Rietveld 408576698