Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2522983002:
Add Media Router result code for user cancellation (Closed)
|
Created:
4 years, 1 month ago by tromeo Modified:
4 years ago CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, media-router+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, asvitkine+watch_chromium.org, Aaron Boodman, mcasas+watch+vc_chromium.org, darin (slow to review), vader-team_google.com Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd Media Router result code for user cancellation
In cases of mirroring cast requests where the user cancels the media
request dialog, provide a route request result code that distinguishes
other errors from a user-triggered cancellation. The return code is
added to sync up the necessary files with the Media Router component
extension code.
Committed: https://crrev.com/cb7a3e4d33a7059b2734ba7708db0116c241cb43
Cr-Commit-Position: refs/heads/master@{#435070}
Patch Set 1 #Patch Set 2 : Add missing conversion code #
Messages
Total messages: 37 (24 generated)
The CQ bit was checked by tromeo@google.com
The CQ bit was unchecked by tromeo@google.com
Description was changed from ========== Add Media Router result code for user cancellation In cases of mirroring cast requests where the user cancels the media request dialog, provide a route request result code that distinguishes other errors from a user-triggered cancellation. The return code is added to sync up the necessary files with the Media Router component extension code. ========== to ========== Add Media Router result code for user cancellation In cases of mirroring cast requests where the user cancels the media request dialog, provide a route request result code that distinguishes other errors from a user-triggered cancellation. The return code is added to sync up the necessary files with the Media Router component extension code. ==========
tromeo@google.com changed reviewers: + holte@chromium.org, imcheng@chromium.org
tromeo@google.com changed required reviewers: + holte@chromium.org, imcheng@chromium.org
The CQ bit was checked by tromeo@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Hi, I've added this new enum value as per the file's comments to keep these up to date with the Media Router component extension's code. Please review at your convenience. See cr/139946762 for the MR patch.
The CQ bit was checked by tromeo@google.com
The CQ bit was unchecked by tromeo@google.com
The CQ bit was unchecked by tromeo@google.com
Thanks for the patch. I think you will also need to update https://cs.chromium.org/chromium/src/chrome/browser/media/router/mojo/media_r...
Good catch. Added that and adjusted the comments to make sure that is also synced up.
The CQ bit was checked by tromeo@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
lgtm
The CQ bit was checked by tromeo@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
tromeo@google.com changed reviewers: + kenrb@chromium.org
tromeo@google.com changed required reviewers: + kenrb@chromium.org
Seems I miscalculated the necessary OWNERS.
ipc lgtm
The CQ bit was checked by tromeo@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480450520388670,
"parent_rev": "67dbf902ebb7f8291db54782daa3ac6d7eec9bdd", "commit_rev":
"5a425e59e0ca33f34a80491070c6b02dd2e1a221"}
Message was sent while issue was closed.
Description was changed from ========== Add Media Router result code for user cancellation In cases of mirroring cast requests where the user cancels the media request dialog, provide a route request result code that distinguishes other errors from a user-triggered cancellation. The return code is added to sync up the necessary files with the Media Router component extension code. ========== to ========== Add Media Router result code for user cancellation In cases of mirroring cast requests where the user cancels the media request dialog, provide a route request result code that distinguishes other errors from a user-triggered cancellation. The return code is added to sync up the necessary files with the Media Router component extension code. ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add Media Router result code for user cancellation In cases of mirroring cast requests where the user cancels the media request dialog, provide a route request result code that distinguishes other errors from a user-triggered cancellation. The return code is added to sync up the necessary files with the Media Router component extension code. ========== to ========== Add Media Router result code for user cancellation In cases of mirroring cast requests where the user cancels the media request dialog, provide a route request result code that distinguishes other errors from a user-triggered cancellation. The return code is added to sync up the necessary files with the Media Router component extension code. Committed: https://crrev.com/cb7a3e4d33a7059b2734ba7708db0116c241cb43 Cr-Commit-Position: refs/heads/master@{#435070} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/cb7a3e4d33a7059b2734ba7708db0116c241cb43 Cr-Commit-Position: refs/heads/master@{#435070} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
