Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Unified Diff: src/wasm/wasm-module-builder.cc

Issue 2522953002: [wasm] Move asm.js offset table to compiled module (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/wasm/wasm-module-builder.cc
diff --git a/src/wasm/wasm-module-builder.cc b/src/wasm/wasm-module-builder.cc
index 290e98ecf8c224bb68f132669230541f23e4565b..7e1002bb4365992602d2293f08bcc044b804b178 100644
--- a/src/wasm/wasm-module-builder.cc
+++ b/src/wasm/wasm-module-builder.cc
@@ -534,6 +534,8 @@ void WasmModuleBuilder::WriteAsmJsOffsetTable(ZoneBuffer& buffer) const {
for (auto function : functions_) {
function->WriteAsmWasmOffsetTable(buffer);
}
+ // Append a 0 to indicate that this is an encoded table.
+ buffer.write_u8(0);
ahaas 2016/11/23 10:08:54 nit: I think it would be good to introduce an enco
Clemens Hammacher 2016/11/23 12:24:36 I think here it is OK, since the comment in the li
}
} // namespace wasm
} // namespace internal
« no previous file with comments | « src/wasm/wasm-module.cc ('k') | src/wasm/wasm-objects.h » ('j') | src/wasm/wasm-objects.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698