Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2522943004: Set the default value for use_corelib_source_files to true on windows as we do not have the source … (Closed)

Created:
4 years ago by siva
Modified:
4 years ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Set the default value for use_corelib_source_files to true on windows as we do not have the source bits baked in. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/93043a36621ae01a5384ac86e67557324c3f3a71

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M runtime/vm/bootstrap.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/globals.h View 1 chunk +7 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
siva
4 years ago (2016-11-23 18:59:46 UTC) #2
siva
TBR=rmacnak
4 years ago (2016-11-23 19:00:33 UTC) #3
rmacnak
lgtm https://codereview.chromium.org/2522943004/diff/1/runtime/vm/globals.h File runtime/vm/globals.h (right): https://codereview.chromium.org/2522943004/diff/1/runtime/vm/globals.h#newcode139 runtime/vm/globals.h:139: // Default value for flag --use-corelib-source-files. Why not ...
4 years ago (2016-11-23 19:08:45 UTC) #4
siva
4 years ago (2016-11-23 19:09:28 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
93043a36621ae01a5384ac86e67557324c3f3a71 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698