ios/web/webui/crw_web_ui_manager.mm - Issue 2522943003: [iOS/ARC] Fix a violation of ODR in base::BindBlock under ARC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/webui/crw_web_ui_manager.mm

Issue 2522943003: [iOS/ARC] Fix a violation of ODR in base::BindBlock under ARC. (Closed)

Patch Set: Use EXPECT_NSEQ instead of EXPECT_EQ/EXPECT_TRUE. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/webui/crw_web_ui_manager.mm

diff --git a/ios/web/webui/crw_web_ui_manager.mm b/ios/web/webui/crw_web_ui_manager.mm

index 75a1d8e9de79553f4412d0a08d01f49a4a16cd17..049f041bf3d6bee0b8f765f026408b66f4b67327 100644

--- a/ios/web/webui/crw_web_ui_manager.mm

+++ b/ios/web/webui/crw_web_ui_manager.mm

@@ -91,7 +91,7 @@ const char kScriptCommandPrefix[] = "webui";

new web::WebStateObserverBridge(webState, self));

base::WeakNSObject<CRWWebUIManager> weakSelf(self);

_webState->AddScriptCommandCallback(

- base::BindBlock(

+ base::BindBlockArc(

^bool(const base::DictionaryValue& message, const GURL&, bool) {

return [weakSelf handleWebUIJSMessage:message];

}),

« no previous file with comments | « ios/web/net/request_tracker_impl.mm ('k') | ios/web/webui/mojo_facade.mm » ('j') | no next file with comments »