Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2964)

Unified Diff: base/mac/scoped_nsobject_unittest_arc.mm

Issue 2522943003: [iOS/ARC] Fix a violation of ODR in base::BindBlock under ARC. (Closed)
Patch Set: Use EXPECT_NSEQ instead of EXPECT_EQ/EXPECT_TRUE. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/mac/scoped_nsobject_unittest_arc.mm
diff --git a/base/mac/scoped_nsobject_unittest_arc.mm b/base/mac/scoped_nsobject_unittest_arc.mm
index 1f69c5640670d6e1d7451b0c8ebd366213be92c3..5cbf3f83833effc65eba1f4db8bc03f50528f262 100644
--- a/base/mac/scoped_nsobject_unittest_arc.mm
+++ b/base/mac/scoped_nsobject_unittest_arc.mm
@@ -14,12 +14,6 @@
#error "This file requires ARC support."
#endif
-// This free-function is there to ensure that the object file in not discarded
-// at link time when building with gyp (it is required because targets is built
-// as a static library with gyp and not source set which cause the object file
-// to be discarded if no symbol is used). Remove once gyp support is dropped.
-void ScopedNSObjectUnittestArcLinkerWorkaround() {}
-
namespace {
template <typename NST>
« no previous file with comments | « base/mac/scoped_nsobject_unittest.mm ('k') | ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698