Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 252293003: cc: Make LTHI::NotifyTileInitialized more generic. (Closed)

Created:
6 years, 7 months ago by vmpstr
Modified:
6 years, 7 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Make LTHI::NotifyTileInitialized more generic. This patch forwards NotifyTileInitialized to layer_impl, which makes it easier to add more special handling per layer, instead of putting extra logic in LTHI. R=enne Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267109

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M cc/layers/layer_impl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/layers/picture_layer_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +13 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
vmpstr
Please take a look.
6 years, 7 months ago (2014-04-29 21:00:11 UTC) #1
enne (OOO)
lgtm
6 years, 7 months ago (2014-04-29 21:13:34 UTC) #2
vmpstr
The CQ bit was checked by vmpstr@chromium.org
6 years, 7 months ago (2014-04-29 21:14:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/252293003/20001
6 years, 7 months ago (2014-04-29 21:16:41 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 22:01:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 22:01:59 UTC) #6
vmpstr
The CQ bit was checked by vmpstr@chromium.org
6 years, 7 months ago (2014-04-29 22:13:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/252293003/20001
6 years, 7 months ago (2014-04-29 22:16:12 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 07:00:36 UTC) #9
Message was sent while issue was closed.
Change committed as 267109

Powered by Google App Engine
This is Rietveld 408576698