Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2522923002: Fuchsia sockets: (Closed)

Created:
4 years ago by rmacnak
Modified:
4 years ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fuchsia sockets: - Enable FDUtils::AvailableBytes. - Disable Socket::SetNoDelay. - Implement Socket::GetRemotePeer same as Linux. - Implement Socket::ParseAddress same as Linux. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/b83fb067418310edb6fed414c449902f710fffeb

Patch Set 1 #

Total comments: 2

Patch Set 2 : CL format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -14 lines) Patch
M runtime/bin/fdutils_fuchsia.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M runtime/bin/socket_fuchsia.cc View 1 3 chunks +22 lines, -6 lines 0 comments Download
M runtime/tests/vm/dart/hello_fuchsia_test.dart View 4 chunks +29 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
4 years ago (2016-11-22 18:53:52 UTC) #2
siva
lgtm https://codereview.chromium.org/2522923002/diff/1/runtime/tests/vm/dart/hello_fuchsia_test.dart File runtime/tests/vm/dart/hello_fuchsia_test.dart (right): https://codereview.chromium.org/2522923002/diff/1/runtime/tests/vm/dart/hello_fuchsia_test.dart#newcode236 runtime/tests/vm/dart/hello_fuchsia_test.dart:236: // print("testSimpleReadWrite done"); Why is this still commented ...
4 years ago (2016-11-22 20:32:43 UTC) #3
rmacnak
https://codereview.chromium.org/2522923002/diff/1/runtime/tests/vm/dart/hello_fuchsia_test.dart File runtime/tests/vm/dart/hello_fuchsia_test.dart (right): https://codereview.chromium.org/2522923002/diff/1/runtime/tests/vm/dart/hello_fuchsia_test.dart#newcode236 runtime/tests/vm/dart/hello_fuchsia_test.dart:236: // print("testSimpleReadWrite done"); On 2016/11/22 20:32:43, siva wrote: > ...
4 years ago (2016-11-22 20:46:46 UTC) #4
rmacnak
4 years ago (2016-11-22 20:49:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b83fb067418310edb6fed414c449902f710fffeb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698