Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Issue 2522883002: [turbofan] Fix representation changes for unsigned values used as checked-signed values. (Closed)

Created:
4 years ago by Jarin
Modified:
4 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix representation changes for unsigned values used as checked-signed values. BUG=chromium:664117 Committed: https://crrev.com/d7aae405c759e4684c4864a8cc07ad3552bde13a Cr-Commit-Position: refs/heads/master@{#41173}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -19 lines) Patch
M src/compiler/representation-change.cc View 3 chunks +19 lines, -19 lines 0 comments Download
A test/mjsunit/compiler/regress-664117.js View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Jarin
Could you take a look, please?
4 years ago (2016-11-22 10:52:53 UTC) #4
Benedikt Meurer
LGTM, thanks for fixing. Probably needs back-merging.
4 years ago (2016-11-22 11:52:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522883002/1
4 years ago (2016-11-22 12:05:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-22 12:07:23 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-22 12:07:50 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7aae405c759e4684c4864a8cc07ad3552bde13a
Cr-Commit-Position: refs/heads/master@{#41173}

Powered by Google App Engine
This is Rietveld 408576698