Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2522773002: MD Settings: extension-controlled indicators for default search engine (Closed)

Created:
4 years, 1 month ago by Dan Beam
Modified:
4 years ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, extensions-reviews_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: extension-controlled indicators for default search engine R=dpapad@chromium.org BUG=614265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e1edd3db1fcc89ec9851cd8592d96ba0520937e3 Cr-Commit-Position: refs/heads/master@{#434103}

Patch Set 1 #

Total comments: 2

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -21 lines) Patch
M chrome/browser/extensions/api/settings_private/prefs_util.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/basic_page/basic_page.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/search_page/search_page.html View 2 chunks +33 lines, -10 lines 0 comments Download
M chrome/browser/resources/settings/search_page/search_page.js View 3 chunks +16 lines, -9 lines 0 comments Download
M chrome/test/data/webui/settings/search_page_test.js View 1 1 chunk +25 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (11 generated)
Dan Beam
4 years, 1 month ago (2016-11-22 03:29:44 UTC) #2
Dan Beam
screenshot: http://i.imgur.com/kNmqGaq.png the setup to override the default search provider is ... fairly elaborate and ...
4 years, 1 month ago (2016-11-22 03:30:46 UTC) #5
dpapad
Can we add a test at https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/search_page_test.js ensuring that the <select> is disabled when it ...
4 years, 1 month ago (2016-11-22 18:35:50 UTC) #8
Dan Beam
On 2016/11/22 18:35:50, dpapad wrote: > Can we add a test at > https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/search_page_test.js > ...
4 years ago (2016-11-23 02:15:14 UTC) #9
dpapad
LGTM
4 years ago (2016-11-23 02:19:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522773002/20001
4 years ago (2016-11-23 03:07:46 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-23 03:29:44 UTC) #17
commit-bot: I haz the power
4 years ago (2016-11-23 03:31:25 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e1edd3db1fcc89ec9851cd8592d96ba0520937e3
Cr-Commit-Position: refs/heads/master@{#434103}

Powered by Google App Engine
This is Rietveld 408576698