MD Settings: extension-controlled indicators for default search engine

MD Settings: extension-controlled indicators for default search engine

R=dpapad@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e1edd3db1fcc89ec9851cd8592d96ba0520937e3
Cr-Commit-Position: refs/heads/master@{#434103}

[Dan Beam, 2016-11-22 03:28:11]

Description was changed from

==========
MD Settings: extension-controlled indicators for default search engine

R=dpapad@chromium.org
BUG=614265
==========

to

==========
MD Settings: extension-controlled indicators for default search engine

R=dpapad@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-11-22 03:29:47]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 03:30:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-11-22 03:30:46]

screenshot: http://i.imgur.com/kNmqGaq.png

the setup to override the default search provider is ... fairly elaborate and
error-prone :(

[commit-bot: I haz the power, 2016-11-22 05:39:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 05:39:05]

Dry run: This issue passed the CQ dry run.

[dpapad, 2016-11-22 18:35:50]

Can we add a test at
https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/search_p...
ensuring that the <select> is disabled when it should be disabled?

https://codereview.chromium.org/2522773002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/search_page/search_page.js (right):

https://codereview.chromium.org/2522773002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_page/search_page.js:55:
onManageSearchEnginesTap_: function() {
Does the "manage search engines" UI also need to be updated when the default
search engine is controlled by an extension? Asking because that UI also allows
changing the default search engine.

[Dan Beam, 2016-11-23 02:15:14]

On 2016/11/22 18:35:50, dpapad wrote:
> Can we add a test at
>
https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/search_p...
> ensuring that the <select> is disabled when it should be disabled?

Done.

https://codereview.chromium.org/2522773002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/search_page/search_page.js (right):

https://codereview.chromium.org/2522773002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_page/search_page.js:55:
onManageSearchEnginesTap_: function() {
On 2016/11/22 18:35:50, dpapad wrote:
> Does the "manage search engines" UI also need to be updated when the default
> search engine is controlled by an extension? Asking because that UI also
allows
> changing the default search engine.

yes :)

[dpapad, 2016-11-23 02:19:00]

LGTM

[Dan Beam, 2016-11-23 02:24:19]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 02:24:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-11-23 03:07:34]

The CQ bit was unchecked by dbeam@chromium.org

[Dan Beam, 2016-11-23 03:07:39]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-11-23 03:07:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 03:29:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479870459307810,
"parent_rev": "36a730d68c2e445e2d3cd00214841cd952cff0ca", "commit_rev":
"32640500311ae0d4b15fdd047f5b20658c432e53"}

[commit-bot: I haz the power, 2016-11-23 03:29:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-23 03:31:24]

Description was changed from

==========
MD Settings: extension-controlled indicators for default search engine

R=dpapad@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: extension-controlled indicators for default search engine

R=dpapad@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e1edd3db1fcc89ec9851cd8592d96ba0520937e3
Cr-Commit-Position: refs/heads/master@{#434103}
==========

[commit-bot: I haz the power, 2016-11-23 03:31:25]

Patchset 2 (id:??) landed as
https://crrev.com/e1edd3db1fcc89ec9851cd8592d96ba0520937e3
Cr-Commit-Position: refs/heads/master@{#434103}