Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js

Issue 2522733002: Do not prompt for reload when security panel is opened on an interstitial (Closed)
Patch Set: dgozman suggestion Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
index 5a0ed86e882bedfe6db800aa34a05b03deeb0692..1d4bcd8323e6a13b0b52ddd35e8f2ea64fd4070a 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
@@ -55,6 +55,7 @@ SDK.ResourceTreeModel = class extends SDK.SDKModel {
this._pendingReloadOptions = null;
this._reloadSuspensionCount = 0;
+ this._isInterstitialShowing = false;
}
/**
@@ -116,6 +117,20 @@ SDK.ResourceTreeModel = class extends SDK.SDKModel {
}
/**
+ * @return {boolean}
+ */
+ isInterstitialShowing() {
+ return this._isInterstitialShowing;
+ }
+
+ /**
+ * @param {boolean=} showing
+ */
+ setIsInterstitialShowing(showing) {
+ this._isInterstitialShowing = showing;
+ }
+
+ /**
* @param {!SDK.ResourceTreeFrame} frame
* @param {boolean=} aboutToNavigate
*/
@@ -859,6 +874,7 @@ SDK.PageDispatcher = class {
* @override
*/
interstitialShown() {
+ this._resourceTreeModel.setIsInterstitialShowing(true);
dgozman 2016/11/29 02:07:23 Let's just assign directly to a private field here
estark 2016/11/29 02:11:36 Done.
this._resourceTreeModel.dispatchEventToListeners(SDK.ResourceTreeModel.Events.InterstitialShown);
}
@@ -866,6 +882,7 @@ SDK.PageDispatcher = class {
* @override
*/
interstitialHidden() {
+ this._resourceTreeModel.setIsInterstitialShowing(false);
this._resourceTreeModel.dispatchEventToListeners(SDK.ResourceTreeModel.Events.InterstitialHidden);
}

Powered by Google App Engine
This is Rietveld 408576698