Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js

Issue 2522733002: Do not prompt for reload when security panel is opened on an interstitial (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js b/third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js
index 8e65e9a31baf2f9db04c508d5ba9650c4e2b27a8..4594e77ff76829f4aa249edb4bcd085595a5f3e7 100644
--- a/third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js
@@ -76,12 +76,14 @@ Security.PageSecurityState = class {
* @param {!Array<!Protocol.Security.SecurityStateExplanation>} explanations
* @param {?Protocol.Security.InsecureContentStatus} insecureContentStatus
* @param {boolean} schemeIsCryptographic
+ * @param {boolean} interstitialIsShowing
*/
- constructor(securityState, explanations, insecureContentStatus, schemeIsCryptographic) {
+ constructor(securityState, explanations, insecureContentStatus, schemeIsCryptographic, interstitialIsShowing) {
this.securityState = securityState;
this.explanations = explanations;
this.insecureContentStatus = insecureContentStatus;
this.schemeIsCryptographic = schemeIsCryptographic;
+ this.interstitialIsShowing = interstitialIsShowing;
}
};
@@ -100,10 +102,12 @@ Security.SecurityDispatcher = class {
* @param {!Array<!Protocol.Security.SecurityStateExplanation>=} explanations
* @param {!Protocol.Security.InsecureContentStatus=} insecureContentStatus
* @param {boolean=} schemeIsCryptographic
+ * @param {boolean=} interstitialIsShowing
*/
- securityStateChanged(securityState, explanations, insecureContentStatus, schemeIsCryptographic) {
+ securityStateChanged(securityState, explanations, insecureContentStatus, schemeIsCryptographic, interstitialIsShowing) {
+ console.log(interstitialIsShowing);
var pageSecurityState = new Security.PageSecurityState(
- securityState, explanations || [], insecureContentStatus || null, schemeIsCryptographic || false);
+ securityState, explanations || [], insecureContentStatus || null, schemeIsCryptographic || false, interstitialIsShowing || false);
this._model.dispatchEventToListeners(Security.SecurityModel.Events.SecurityStateChanged, pageSecurityState);
}
};

Powered by Google App Engine
This is Rietveld 408576698