Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

Issue 2522733002: Do not prompt for reload when security panel is opened on an interstitial (Closed)
Patch Set: remove isInterstitialShowing setter Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @implements {SDK.TargetManager.Observer} 5 * @implements {SDK.TargetManager.Observer}
6 * @unrestricted 6 * @unrestricted
7 */ 7 */
8 Security.SecurityPanel = class extends UI.PanelWithSidebar { 8 Security.SecurityPanel = class extends UI.PanelWithSidebar {
9 constructor() { 9 constructor() {
10 super('security'); 10 super('security');
(...skipping 273 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 var resourceTreeModel = SDK.ResourceTreeModel.fromTarget(target); 284 var resourceTreeModel = SDK.ResourceTreeModel.fromTarget(target);
285 if (resourceTreeModel) { 285 if (resourceTreeModel) {
286 listeners = listeners.concat([ 286 listeners = listeners.concat([
287 resourceTreeModel.addEventListener( 287 resourceTreeModel.addEventListener(
288 SDK.ResourceTreeModel.Events.MainFrameNavigated, this._onMainFrameNa vigated, this), 288 SDK.ResourceTreeModel.Events.MainFrameNavigated, this._onMainFrameNa vigated, this),
289 resourceTreeModel.addEventListener( 289 resourceTreeModel.addEventListener(
290 SDK.ResourceTreeModel.Events.InterstitialShown, this._onInterstitial Shown, this), 290 SDK.ResourceTreeModel.Events.InterstitialShown, this._onInterstitial Shown, this),
291 resourceTreeModel.addEventListener( 291 resourceTreeModel.addEventListener(
292 SDK.ResourceTreeModel.Events.InterstitialHidden, this._onInterstitia lHidden, this), 292 SDK.ResourceTreeModel.Events.InterstitialHidden, this._onInterstitia lHidden, this),
293 ]); 293 ]);
294
295 if (resourceTreeModel.isInterstitialShowing())
296 this._onInterstitialShown();
294 } 297 }
295 298
296 var networkManager = SDK.NetworkManager.fromTarget(target); 299 var networkManager = SDK.NetworkManager.fromTarget(target);
297 if (networkManager) { 300 if (networkManager) {
298 listeners = listeners.concat([ 301 listeners = listeners.concat([
299 networkManager.addEventListener(SDK.NetworkManager.Events.ResponseReceiv ed, this._onResponseReceived, this), 302 networkManager.addEventListener(SDK.NetworkManager.Events.ResponseReceiv ed, this._onResponseReceived, this),
300 networkManager.addEventListener(SDK.NetworkManager.Events.RequestFinishe d, this._onRequestFinished, this), 303 networkManager.addEventListener(SDK.NetworkManager.Events.RequestFinishe d, this._onRequestFinished, this),
301 ]); 304 ]);
302 } 305 }
303 306
(...skipping 729 matching lines...) Expand 10 before | Expand all | Expand 10 after
1033 var row = this._element.createChild('div', 'details-table-row'); 1036 var row = this._element.createChild('div', 'details-table-row');
1034 row.createChild('div').textContent = key; 1037 row.createChild('div').textContent = key;
1035 1038
1036 var valueDiv = row.createChild('div'); 1039 var valueDiv = row.createChild('div');
1037 if (typeof value === 'string') 1040 if (typeof value === 'string')
1038 valueDiv.textContent = value; 1041 valueDiv.textContent = value;
1039 else 1042 else
1040 valueDiv.appendChild(value); 1043 valueDiv.appendChild(value);
1041 } 1044 }
1042 }; 1045 };
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698