Do not prompt for reload when security panel is opened on an interstitial

third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 37 matching lines @@
     this._agent = target.pageAgent();
     this._agent.enable();
     this._securityOriginManager = securityOriginManager;
 
     this._fetchResourceTree();
 
     target.registerPageDispatcher(new SDK.PageDispatcher(this));
 
     this._pendingReloadOptions = null;
     this._reloadSuspensionCount = 0;
+    this._isInterstitialShowing = false;
   }
 
   /**
    * @param {!SDK.Target} target
    * @return {?SDK.ResourceTreeModel}
    */
   static fromTarget(target) {
     return /** @type {?SDK.ResourceTreeModel} */ (target.model(SDK.ResourceTreeModel));
   }
 
@@ skipping 41 matching lines @@
   }
 
   /**
    * @return {boolean}
    */
   cachedResourcesLoaded() {
     return this._cachedResourcesProcessed;
   }
 
   /**
+   * @return {boolean}
+   */
+  isInterstitialShowing() {
+    return this._isInterstitialShowing;
+  }
+
+  /**
+   * @param {boolean=} showing
+   */
+  setIsInterstitialShowing(showing) {
+    this._isInterstitialShowing = showing;
+  }
+
+  /**
    * @param {!SDK.ResourceTreeFrame} frame
    * @param {boolean=} aboutToNavigate
    */
   _addFrame(frame, aboutToNavigate) {
     this._frames.set(frame.id, frame);
     if (frame.isMainFrame()) {
       this.mainFrame = frame;
       this._securityOriginManager.setMainSecurityOrigin(frame.url);
     }
     this.dispatchEventToListeners(SDK.ResourceTreeModel.Events.FrameAdded, frame);
@@ skipping 723 matching lines @@
    * @param {!Protocol.DOM.RGBA} color
    */
   colorPicked(color) {
     this._resourceTreeModel.dispatchEventToListeners(SDK.ResourceTreeModel.Events.ColorPicked, color);
   }
 
   /**
    * @override
    */
   interstitialShown() {
+    this._resourceTreeModel.setIsInterstitialShowing(true);

[dgozman, 2016/11/29 02:07:23]

Let's just assign directly to a private field here (it's file-private), and do
not expose the setter.

[estark, 2016/11/29 02:11:36]

Done.

     this._resourceTreeModel.dispatchEventToListeners(SDK.ResourceTreeModel.Events.InterstitialShown);
   }
 
   /**
    * @override
    */
   interstitialHidden() {
+    this._resourceTreeModel.setIsInterstitialShowing(false);
     this._resourceTreeModel.dispatchEventToListeners(SDK.ResourceTreeModel.Events.InterstitialHidden);
   }
 
   /**
    * @override
    */
   navigationRequested() {
     // Frontend is not interested in when navigations are requested.
   }
 };